Repository navigation
[softposconfiguration] Code generation: update services and models - #516
AdyenAutomationBot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the softPOSConfiguration service, including the AdyenSoftPOSConfigurationApi and SessionAuthenticationApi classes to support SoftPOS configuration. A review comment points out a critical issue where setting self.service to "softPOSConfiguration" will cause a KeyError in the client's version lookup, and suggests changing it to "sessionAuthentication" to ensure compatibility.
|
|
||
| def __init__(self, client=None): | ||
| super().__init__(client=client) | ||
| self.service = "softPOSConfiguration" |
There was a problem hiding this comment.
Setting self.service to "softPOSConfiguration" will cause a KeyError in AdyenClient._set_url_version if any API version is configured on the client, because "softPOSConfiguration" is not a key in the version_lookup dictionary in Adyen/client.py. Changing this to "sessionAuthentication" ensures compatibility with the client's versioning mechanism and correctly maps to self.api_session_authentication_version.
| self.service = "softPOSConfiguration" | |
| self.service = "sessionAuthentication" |
b5cdccb to
6acaec1
Compare
6acaec1 to
3893f97
Compare
|
This PR contains the automated changes for the
softposconfigurationservice.Adyen/adyen-openapi@d449f09
The commit history of this PR reflects the
adyen-openapicommits that have been applied.