Repository navigation
[checkout] Code generation: update services and models - #512
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the calculate_tax and verify_shopper_tax_identification methods to the utility_api.py service. The review feedback highlights that these new methods lack unit test coverage in test/CheckoutUtilityTest.py and recommends adding tests to verify the endpoints.
| def calculate_tax(self, request, idempotency_key=None, **kwargs): | ||
| """ | ||
| Calculate the tax for a transaction. | ||
| """ | ||
| endpoint = self.baseUrl + "/calculateTax" | ||
| method = "POST" | ||
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) |
There was a problem hiding this comment.
The newly added calculate_tax and verify_shopper_tax_identification methods lack unit test coverage in test/CheckoutUtilityTest.py. Please add unit tests to verify these new endpoints. Note that if a test only asserts on the outgoing request (such as method, URL, headers, or body) and does not require a mocked response, the create_client_from_file helper can be called without a mock file path argument, as it defaults to returning an empty response.
References
- When a test only asserts on the outgoing request (such as method, URL, headers, or body) and does not require a mocked response, the
create_client_from_filehelper can be called without a mock file path argument, as it defaults to returning an empty response.
a2279eb to
61885d1
Compare
459643e to
cda3d8e
Compare
f8f6168 to
f9181f1
Compare
f9181f1 to
0e0457c
Compare
|
This PR contains the automated changes for the
checkoutservice.Adyen/adyen-openapi@d449f09
The commit history of this PR reflects the
adyen-openapicommits that have been applied.