From 78bd0166e8027379dbf376e50ff98709e2fac8b9 Mon Sep 17 00:00:00 2001 From: Nick Pirollo Date: Mon, 9 Nov 2026 14:51:04 -0800 Subject: [PATCH 1/3] New Adapter: Sellwild --- .../bidder/sellwild/SellwildBidder.java | 197 ++++++++ .../ext/request/sellwild/ExtImpSellwild.java | 13 + .../config/bidder/SellwildConfiguration.java | 35 ++ .../resources/bidder-config/sellwild.yaml | 16 + .../static/bidder-params/sellwild.json | 22 + .../bidder/sellwild/SellwildBidderTest.java | 423 ++++++++++++++++++ .../org/prebid/server/it/SellwildTest.java | 35 ++ .../test-auction-sellwild-request.json | 24 + .../test-auction-sellwild-response.json | 42 ++ .../sellwild/test-sellwild-bid-request.json | 56 +++ .../sellwild/test-sellwild-bid-response.json | 21 + .../server/it/test-application.properties | 2 + 12 files changed, 886 insertions(+) create mode 100644 src/main/java/org/prebid/server/bidder/sellwild/SellwildBidder.java create mode 100644 src/main/java/org/prebid/server/proto/openrtb/ext/request/sellwild/ExtImpSellwild.java create mode 100644 src/main/java/org/prebid/server/spring/config/bidder/SellwildConfiguration.java create mode 100644 src/main/resources/bidder-config/sellwild.yaml create mode 100644 src/main/resources/static/bidder-params/sellwild.json create mode 100644 src/test/java/org/prebid/server/bidder/sellwild/SellwildBidderTest.java create mode 100644 src/test/java/org/prebid/server/it/SellwildTest.java create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-auction-sellwild-request.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-auction-sellwild-response.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-sellwild-bid-request.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-sellwild-bid-response.json diff --git a/src/main/java/org/prebid/server/bidder/sellwild/SellwildBidder.java b/src/main/java/org/prebid/server/bidder/sellwild/SellwildBidder.java new file mode 100644 index 00000000000..22463fb5194 --- /dev/null +++ b/src/main/java/org/prebid/server/bidder/sellwild/SellwildBidder.java @@ -0,0 +1,197 @@ +package org.prebid.server.bidder.sellwild; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import io.vertx.core.MultiMap; +import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.StringUtils; +import org.prebid.server.bidder.Bidder; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.exception.PreBidException; +import org.prebid.server.json.DecodeException; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.sellwild.ExtImpSellwild; +import org.prebid.server.proto.openrtb.ext.response.BidType; +import org.prebid.server.util.BidderUtil; +import org.prebid.server.util.HttpUtil; +import org.prebid.server.util.Uri; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.function.Function; +import java.util.stream.Collectors; + +public class SellwildBidder implements Bidder { + + private static final TypeReference> SELLWILD_EXT_TYPE_REFERENCE = + new TypeReference<>() { + }; + + private static final String PUBLISHER_ID_MACRO = "PublisherId"; + private static final String OPENRTB_VERSION = "2.6"; + + private final Uri endpointUrl; + private final JacksonMapper mapper; + + public SellwildBidder(String endpointUrl, JacksonMapper mapper) { + this.endpointUrl = Uri.of(endpointUrl); + this.mapper = Objects.requireNonNull(mapper); + } + + @Override + public Result>> makeHttpRequests(BidRequest request) { + final List errors = new ArrayList<>(); + final Map> partnerCodeToImps = new LinkedHashMap<>(); + + for (Imp imp : request.getImp()) { + try { + final ExtImpSellwild extImp = parseImpExt(imp); + validateImpExt(extImp, imp.getId()); + partnerCodeToImps.computeIfAbsent(extImp.getPartnerCode(), key -> new ArrayList<>()).add(imp); + } catch (PreBidException e) { + errors.add(BidderError.badInput(e.getMessage())); + } + } + + final List> httpRequests = partnerCodeToImps.entrySet().stream() + .map(entry -> makeHttpRequest(request, entry.getKey(), entry.getValue())) + .toList(); + + return Result.of(httpRequests, errors); + } + + private ExtImpSellwild parseImpExt(Imp imp) { + try { + return mapper.mapper().convertValue(imp.getExt(), SELLWILD_EXT_TYPE_REFERENCE).getBidder(); + } catch (IllegalArgumentException e) { + throw new PreBidException("Failed to parse bidder parameters for imp %s: %s" + .formatted(imp.getId(), e.getMessage())); + } + } + + private static void validateImpExt(ExtImpSellwild extImp, String impId) { + if (extImp == null) { + throw new PreBidException("Missing bidder parameters for imp " + impId); + } + if (StringUtils.isBlank(extImp.getPartnerCode())) { + throw new PreBidException("Missing partnerCode for imp " + impId); + } + if (StringUtils.isBlank(extImp.getToken())) { + throw new PreBidException("Missing token for imp " + impId); + } + } + + private HttpRequest makeHttpRequest(BidRequest request, String partnerCode, List imps) { + final BidRequest outgoingRequest = request.toBuilder().imp(imps).build(); + final String uri = endpointUrl.replaceMacro(PUBLISHER_ID_MACRO, partnerCode).expand(); + + final MultiMap headers = HttpUtil.headers(); + headers.add(HttpUtil.X_OPENRTB_VERSION_HEADER, OPENRTB_VERSION); + + return BidderUtil.defaultRequest(outgoingRequest, headers, uri, mapper); + } + + @Override + public Result> makeBids(BidderCall httpCall, BidRequest bidRequest) { + try { + final BidResponse bidResponse = mapper.decodeValue(httpCall.getResponse().getBody(), BidResponse.class); + final List errors = new ArrayList<>(); + final List bids = extractBids(bidResponse, httpCall.getRequest().getPayload(), errors); + return Result.of(bids, errors); + } catch (DecodeException e) { + return Result.withError(BidderError.badServerResponse(e.getMessage())); + } + } + + private static List extractBids(BidResponse bidResponse, + BidRequest bidRequest, + List errors) { + + if (bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())) { + return Collections.emptyList(); + } + + final Map impIdToImp = bidRequest == null || bidRequest.getImp() == null + ? Collections.emptyMap() + : bidRequest.getImp().stream() + .collect(Collectors.toMap(Imp::getId, Function.identity(), (first, second) -> first)); + + return bidResponse.getSeatbid().stream() + .filter(Objects::nonNull) + .map(SeatBid::getBid) + .filter(Objects::nonNull) + .flatMap(Collection::stream) + .filter(Objects::nonNull) + .map(bid -> makeBidderBid(bid, bidResponse.getCur(), impIdToImp, errors)) + .filter(Objects::nonNull) + .toList(); + } + + private static BidderBid makeBidderBid(Bid bid, + String currency, + Map impIdToImp, + List errors) { + + try { + return BidderBid.of(bid, getBidType(bid, impIdToImp), currency); + } catch (PreBidException e) { + errors.add(BidderError.badServerResponse(e.getMessage())); + return null; + } + } + + private static BidType getBidType(Bid bid, Map impIdToImp) { + final Imp imp = impIdToImp.get(bid.getImpid()); + if (imp == null) { + throw new PreBidException("unable to find imp %s for bid %s".formatted(bid.getImpid(), bid.getId())); + } + + final Integer markupType = bid.getMtype(); + if (BidderUtil.isNullOrZero(markupType)) { + return getBidTypeFromImp(bid, imp); + } + + return switch (markupType) { + case 1 -> BidType.banner; + case 2 -> BidType.video; + case 4 -> BidType.xNative; + default -> throw new PreBidException( + "Unsupported mtype %d for bid %s".formatted(markupType, bid.getId())); + }; + } + + private static BidType getBidTypeFromImp(Bid bid, Imp imp) { + final List impTypes = new ArrayList<>(); + if (imp.getBanner() != null) { + impTypes.add(BidType.banner); + } + if (imp.getVideo() != null) { + impTypes.add(BidType.video); + } + if (imp.getXNative() != null) { + impTypes.add(BidType.xNative); + } + + if (impTypes.size() != 1) { + throw new PreBidException( + "Unable to determine media type for bid %s: imp %s must have exactly one of banner, video, native" + .formatted(bid.getId(), imp.getId())); + } + + return impTypes.getFirst(); + } +} diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/sellwild/ExtImpSellwild.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/sellwild/ExtImpSellwild.java new file mode 100644 index 00000000000..3c6993843f5 --- /dev/null +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/sellwild/ExtImpSellwild.java @@ -0,0 +1,13 @@ +package org.prebid.server.proto.openrtb.ext.request.sellwild; + +import com.fasterxml.jackson.annotation.JsonProperty; +import lombok.Value; + +@Value(staticConstructor = "of") +public class ExtImpSellwild { + + @JsonProperty("partnerCode") + String partnerCode; + + String token; +} diff --git a/src/main/java/org/prebid/server/spring/config/bidder/SellwildConfiguration.java b/src/main/java/org/prebid/server/spring/config/bidder/SellwildConfiguration.java new file mode 100644 index 00000000000..ff403d1d2c8 --- /dev/null +++ b/src/main/java/org/prebid/server/spring/config/bidder/SellwildConfiguration.java @@ -0,0 +1,35 @@ +package org.prebid.server.spring.config.bidder; + +import org.prebid.server.bidder.BidderDeps; +import org.prebid.server.bidder.sellwild.SellwildBidder; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.spring.config.bidder.model.BidderConfigurationProperties; +import org.prebid.server.spring.config.bidder.util.BidderDepsAssembler; +import org.prebid.server.spring.env.YamlPropertySourceFactory; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.context.annotation.PropertySource; + +@Configuration +@PropertySource(value = "classpath:/bidder-config/sellwild.yaml", factory = YamlPropertySourceFactory.class) +public class SellwildConfiguration { + + private static final String BIDDER_NAME = "sellwild"; + + @Bean("sellwildConfigurationProperties") + @ConfigurationProperties("adapters.sellwild") + BidderConfigurationProperties configurationProperties() { + return new BidderConfigurationProperties(); + } + + @Bean + BidderDeps sellwildBidderDeps(BidderConfigurationProperties sellwildConfigurationProperties, + JacksonMapper mapper) { + + return BidderDepsAssembler.forBidder(BIDDER_NAME) + .withConfig(sellwildConfigurationProperties) + .bidderCreator(config -> new SellwildBidder(config.getEndpoint(), mapper)) + .assemble(); + } +} diff --git a/src/main/resources/bidder-config/sellwild.yaml b/src/main/resources/bidder-config/sellwild.yaml new file mode 100644 index 00000000000..c1937277078 --- /dev/null +++ b/src/main/resources/bidder-config/sellwild.yaml @@ -0,0 +1,16 @@ +adapters: + sellwild: + endpoint: https://exchange.sellwild.com/exchange/openrtb2/{PublisherId} + ortb-version: "2.6" + meta-info: + maintainer-email: prebid@sellwild.com + app-media-types: + - banner + - video + - native + site-media-types: + - banner + - video + - native + supported-vendors: + vendor-id: 0 diff --git a/src/main/resources/static/bidder-params/sellwild.json b/src/main/resources/static/bidder-params/sellwild.json new file mode 100644 index 00000000000..7e4ce1335e4 --- /dev/null +++ b/src/main/resources/static/bidder-params/sellwild.json @@ -0,0 +1,22 @@ +{ + "$schema": "http://json-schema.org/draft-04/schema#", + "title": "Sellwild Adapter Params", + "description": "A schema which validates params accepted by the Sellwild adapter", + "type": "object", + "properties": { + "partnerCode": { + "type": "string", + "description": "Partner code assigned by Sellwild", + "pattern": "^[A-Za-z0-9_-]{1,64}$" + }, + "token": { + "type": "string", + "description": "Partner auth token assigned by Sellwild", + "minLength": 1 + } + }, + "required": [ + "partnerCode", + "token" + ] +} diff --git a/src/test/java/org/prebid/server/bidder/sellwild/SellwildBidderTest.java b/src/test/java/org/prebid/server/bidder/sellwild/SellwildBidderTest.java new file mode 100644 index 00000000000..69957b1bfea --- /dev/null +++ b/src/test/java/org/prebid/server/bidder/sellwild/SellwildBidderTest.java @@ -0,0 +1,423 @@ +package org.prebid.server.bidder.sellwild; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.Banner; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.request.Native; +import com.iab.openrtb.request.Video; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import io.netty.handler.codec.http.HttpHeaderValues; +import io.vertx.core.MultiMap; +import org.junit.jupiter.api.Test; +import org.prebid.server.VertxTest; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.HttpResponse; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.sellwild.ExtImpSellwild; +import org.prebid.server.proto.openrtb.ext.response.BidType; +import org.prebid.server.util.HttpUtil; + +import java.util.List; +import java.util.Map; +import java.util.function.UnaryOperator; + +import static java.util.Arrays.asList; +import static java.util.Collections.singletonList; +import static java.util.function.UnaryOperator.identity; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; +import static org.assertj.core.api.Assertions.tuple; + +public class SellwildBidderTest extends VertxTest { + + private static final String ENDPOINT_URL = "https://test.endpoint.com/openrtb2/{PublisherId}"; + + private final SellwildBidder target = new SellwildBidder(ENDPOINT_URL, jacksonMapper); + + @Test + public void creationShouldFailOnInvalidEndpointUrl() { + assertThatIllegalArgumentException().isThrownBy(() -> new SellwildBidder("invalid_url", jacksonMapper)); + } + + @Test + public void makeHttpRequestsShouldReturnErrorAndSkipImpWhenImpExtCouldNotBeParsed() { + // given + final ObjectNode invalidExt = mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode())); + final BidRequest bidRequest = givenBidRequest( + givenImp(imp -> imp.id("invalid").ext(invalidExt)), + givenImp(imp -> imp.id("valid"))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).satisfiesExactly(error -> { + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_input); + assertThat(error.getMessage()).startsWith("Failed to parse bidder parameters for imp invalid"); + }); + assertThat(result.getValue()) + .extracting(HttpRequest::getPayload) + .flatExtracting(BidRequest::getImp) + .extracting(Imp::getId) + .containsExactly("valid"); + } + + @Test + public void makeHttpRequestsShouldReturnErrorWhenBidderParamsAreMissing() { + // given + final BidRequest bidRequest = givenBidRequest(givenImp(imp -> imp.ext(mapper.createObjectNode()))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()) + .containsExactly(BidderError.badInput("Missing bidder parameters for imp 123")); + } + + @Test + public void makeHttpRequestsShouldReturnErrorWhenPartnerCodeIsBlank() { + // given + final BidRequest bidRequest = givenBidRequest(givenImp(identity(), ExtImpSellwild.of(" ", "token"))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).containsExactly(BidderError.badInput("Missing partnerCode for imp 123")); + } + + @Test + public void makeHttpRequestsShouldReturnErrorWhenTokenIsMissing() { + // given + final BidRequest bidRequest = givenBidRequest(givenImp(identity(), ExtImpSellwild.of("partner", null))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).containsExactly(BidderError.badInput("Missing token for imp 123")); + } + + @Test + public void makeHttpRequestsShouldGroupImpsByPartnerCodePreservingOrder() { + // given + final BidRequest bidRequest = givenBidRequest( + givenImp(imp -> imp.id("imp1"), ExtImpSellwild.of("partnerB", "token1")), + givenImp(imp -> imp.id("imp2"), ExtImpSellwild.of("partnerA", "token2")), + givenImp(imp -> imp.id("imp3"), ExtImpSellwild.of("partnerB", "token3"))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).satisfiesExactly( + request -> { + assertThat(request.getUri()).isEqualTo("https://test.endpoint.com/openrtb2/partnerB"); + assertThat(request.getPayload().getImp()).extracting(Imp::getId).containsExactly("imp1", "imp3"); + assertThat(request.getImpIds()).containsExactlyInAnyOrder("imp1", "imp3"); + }, + request -> { + assertThat(request.getUri()).isEqualTo("https://test.endpoint.com/openrtb2/partnerA"); + assertThat(request.getPayload().getImp()).extracting(Imp::getId).containsExactly("imp2"); + assertThat(request.getImpIds()).containsExactly("imp2"); + }); + } + + @Test + public void makeHttpRequestsShouldEscapePartnerCodeInUrl() { + // given + final BidRequest bidRequest = givenBidRequest( + givenImp(identity(), ExtImpSellwild.of("a b/c?d", "token"))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .extracting(HttpRequest::getUri) + .containsExactly("https://test.endpoint.com/openrtb2/a%20b%2Fc%3Fd"); + } + + @Test + public void makeHttpRequestsShouldLeaveImpExtUntouched() { + // given + final ObjectNode impExt = mapper.valueToTree(ExtPrebid.of(null, ExtImpSellwild.of("partner", "secret"))); + impExt.put("tid", "transaction-id"); + final BidRequest bidRequest = givenBidRequest(givenImp(imp -> imp.ext(impExt))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .extracting(HttpRequest::getPayload) + .flatExtracting(BidRequest::getImp) + .extracting(Imp::getExt) + .containsExactly(impExt); + assertThat(impExt.at("/bidder/token").asText()).isEqualTo("secret"); + assertThat(impExt.at("/bidder/partnerCode").asText()).isEqualTo("partner"); + } + + @Test + public void makeHttpRequestsShouldSetExpectedHeaders() { + // given + final BidRequest bidRequest = givenBidRequest(givenImp(identity())); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getValue()) + .extracting(HttpRequest::getHeaders) + .flatExtracting(MultiMap::entries) + .extracting(Map.Entry::getKey, Map.Entry::getValue) + .containsExactlyInAnyOrder( + tuple(HttpUtil.CONTENT_TYPE_HEADER.toString(), HttpUtil.APPLICATION_JSON_CONTENT_TYPE), + tuple(HttpUtil.ACCEPT_HEADER.toString(), HttpHeaderValues.APPLICATION_JSON.toString()), + tuple(HttpUtil.X_OPENRTB_VERSION_HEADER.toString(), "2.6")); + } + + @Test + public void makeBidsShouldReturnErrorIfResponseBodyCouldNotBeParsed() { + // given + final BidderCall httpCall = givenHttpCall(givenBidRequest(givenImp(identity())), "invalid"); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).satisfiesExactly(error -> { + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response); + assertThat(error.getMessage()).startsWith("Failed to decode: Unrecognized token"); + }); + } + + @Test + public void makeBidsShouldReturnEmptyListIfBidResponseIsNull() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidRequest(givenImp(identity())), mapper.writeValueAsString(null)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnEmptyListIfSeatBidIsEmpty() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidRequest(givenImp(identity())), + mapper.writeValueAsString(BidResponse.builder().cur("USD").build())); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldResolveBidTypeFromMtype() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidRequest(givenImp(identity())), + givenBidResponse( + givenBid("bid1", "123", 1), + givenBid("bid2", "123", 2), + givenBid("bid4", "123", 4))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .extracting(bidderBid -> bidderBid.getBid().getId(), BidderBid::getType) + .containsExactly( + tuple("bid1", BidType.banner), + tuple("bid2", BidType.video), + tuple("bid4", BidType.xNative)); + } + + @Test + public void makeBidsShouldReturnErrorAndSkipBidWithUnsupportedMtype() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidRequest(givenImp(identity())), + givenBidResponse(givenBid("audio", "123", 3), givenBid("valid", "123", 1))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()) + .containsExactly(BidderError.badServerResponse("Unsupported mtype 3 for bid audio")); + assertThat(result.getValue()) + .extracting(bidderBid -> bidderBid.getBid().getId()) + .containsExactly("valid"); + } + + @Test + public void makeBidsShouldFallBackToImpMediaTypeWhenMtypeIsAbsent() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidRequest( + givenImp(imp -> imp.id("bannerImp")), + givenImp(imp -> imp.id("videoImp").banner(null).video(Video.builder().build())), + givenImp(imp -> imp.id("nativeImp").banner(null).xNative(Native.builder().build()))), + givenBidResponse( + givenBid("bid1", "bannerImp", null), + givenBid("bid2", "videoImp", 0), + givenBid("bid3", "nativeImp", null))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .extracting(bidderBid -> bidderBid.getBid().getId(), BidderBid::getType) + .containsExactly( + tuple("bid1", BidType.banner), + tuple("bid2", BidType.video), + tuple("bid3", BidType.xNative)); + } + + @Test + public void makeBidsShouldReturnErrorWhenMtypeIsAbsentAndImpIsMultiFormat() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidRequest(givenImp(imp -> imp.video(Video.builder().build()))), + givenBidResponse(givenBid("bid1", "123", null))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).containsExactly(BidderError.badServerResponse( + "Unable to determine media type for bid bid1: imp 123 must have exactly one of banner, video, native")); + } + + @Test + public void makeBidsShouldReturnErrorWhenMtypeIsAbsentAndImpIsNotFound() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidRequest(givenImp(identity())), + givenBidResponse(givenBid("bid1", "unknown", null))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()) + .containsExactly(BidderError.badServerResponse("unable to find imp unknown for bid bid1")); + } + + @Test + public void makeBidsShouldRejectBidForImpNotInOutgoingRequestEvenWhenMtypeIsSet() + throws JsonProcessingException { + + // given + final BidRequest bidRequest = givenBidRequest( + givenImp(imp -> imp.id("impA"), ExtImpSellwild.of("partnerA", "tokenA")), + givenImp(imp -> imp.id("impB"), ExtImpSellwild.of("partnerB", "tokenB"))); + final List> httpRequests = target.makeHttpRequests(bidRequest).getValue(); + assertThat(httpRequests).hasSize(2); + + final BidderCall partnerACall = BidderCall.succeededHttp( + httpRequests.getFirst(), + HttpResponse.of(200, null, givenBidResponse( + givenBid("bidA", "impA", 1), + givenBid("bidB", "impB", 1))), + null); + + // when + final Result> result = target.makeBids(partnerACall, bidRequest); + + // then + assertThat(result.getErrors()) + .containsExactly(BidderError.badServerResponse("unable to find imp impB for bid bidB")); + assertThat(result.getValue()) + .extracting(bidderBid -> bidderBid.getBid().getId(), BidderBid::getType) + .containsExactly(tuple("bidA", BidType.banner)); + } + + @Test + public void makeBidsShouldUseCurrencyFromResponse() throws JsonProcessingException { + // given + final BidResponse bidResponse = BidResponse.builder() + .cur("EUR") + .seatbid(singletonList(SeatBid.builder() + .seat("sellwild") + .bid(singletonList(givenBid("bid1", "123", 1))) + .build())) + .build(); + final BidderCall httpCall = givenHttpCall( + givenBidRequest(givenImp(identity())), mapper.writeValueAsString(bidResponse)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsExactly(BidderBid.of(givenBid("bid1", "123", 1), BidType.banner, "EUR")); + } + + private static BidRequest givenBidRequest(Imp... imps) { + return BidRequest.builder().id("request-id").imp(asList(imps)).build(); + } + + private static Imp givenImp(UnaryOperator impCustomizer) { + return givenImp(impCustomizer, ExtImpSellwild.of("partner", "token")); + } + + private static Imp givenImp(UnaryOperator impCustomizer, ExtImpSellwild extImp) { + return impCustomizer.apply(Imp.builder() + .id("123") + .banner(Banner.builder().w(300).h(250).build()) + .ext(mapper.valueToTree(ExtPrebid.of(null, extImp)))) + .build(); + } + + private static Bid givenBid(String id, String impId, Integer mtype) { + return Bid.builder().id(id).impid(impId).mtype(mtype).build(); + } + + private static String givenBidResponse(Bid... bids) throws JsonProcessingException { + return mapper.writeValueAsString(BidResponse.builder() + .cur("USD") + .seatbid(singletonList(SeatBid.builder().seat("sellwild").bid(asList(bids)).build())) + .build()); + } + + private static BidderCall givenHttpCall(BidRequest bidRequest, String body) { + return BidderCall.succeededHttp( + HttpRequest.builder().payload(bidRequest).build(), + HttpResponse.of(200, null, body), + null); + } +} diff --git a/src/test/java/org/prebid/server/it/SellwildTest.java b/src/test/java/org/prebid/server/it/SellwildTest.java new file mode 100644 index 00000000000..663560ce377 --- /dev/null +++ b/src/test/java/org/prebid/server/it/SellwildTest.java @@ -0,0 +1,35 @@ +package org.prebid.server.it; + +import io.restassured.response.Response; +import org.json.JSONException; +import org.junit.jupiter.api.Test; +import org.prebid.server.model.Endpoint; + +import java.io.IOException; + +import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; +import static com.github.tomakehurst.wiremock.client.WireMock.equalTo; +import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson; +import static com.github.tomakehurst.wiremock.client.WireMock.post; +import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; +import static java.util.Collections.singletonList; + +public class SellwildTest extends IntegrationTest { + + @Test + public void openrtb2AuctionShouldRespondWithBidsFromSellwild() throws IOException, JSONException { + // given + WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/sellwild-exchange/test-partner")) + .withHeader("x-openrtb-version", equalTo("2.6")) + .withRequestBody(equalToJson(jsonFrom("openrtb2/sellwild/test-sellwild-bid-request.json"))) + .willReturn(aResponse().withBody(jsonFrom("openrtb2/sellwild/test-sellwild-bid-response.json")))); + + // when + final Response response = responseFor("openrtb2/sellwild/test-auction-sellwild-request.json", + Endpoint.openrtb2_auction); + + // then + assertJsonEquals("openrtb2/sellwild/test-auction-sellwild-response.json", response, + singletonList("sellwild")); + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-auction-sellwild-request.json b/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-auction-sellwild-request.json new file mode 100644 index 00000000000..fb10e31c7d9 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-auction-sellwild-request.json @@ -0,0 +1,24 @@ +{ + "id": "request_id", + "imp": [ + { + "id": "imp_id", + "banner": { + "w": 300, + "h": 250 + }, + "ext": { + "sellwild": { + "partnerCode": "test-partner", + "token": "test-token" + } + } + } + ], + "tmax": 5000, + "regs": { + "ext": { + "gdpr": 0 + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-auction-sellwild-response.json b/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-auction-sellwild-response.json new file mode 100644 index 00000000000..dbec6b64847 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-auction-sellwild-response.json @@ -0,0 +1,42 @@ +{ + "id": "request_id", + "seatbid": [ + { + "bid": [ + { + "id": "bid_id", + "impid": "imp_id", + "exp": 300, + "price": 3.33, + "adm": "adm001", + "crid": "crid", + "w": 300, + "h": 250, + "mtype": 1, + "ext": { + "prebid": { + "type": "banner", + "meta": { + "adaptercode": "sellwild" + } + }, + "origbidcpm": 3.33, + "origbidcur": "USD" + } + } + ], + "seat": "sellwild", + "group": 0 + } + ], + "cur": "USD", + "ext": { + "responsetimemillis": { + "sellwild": "{{ sellwild.response_time_ms }}" + }, + "prebid": { + "auctiontimestamp": 0 + }, + "tmaxrequest": 5000 + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-sellwild-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-sellwild-bid-request.json new file mode 100644 index 00000000000..7e0e9acbab7 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-sellwild-bid-request.json @@ -0,0 +1,56 @@ +{ + "id": "request_id", + "imp": [ + { + "id": "imp_id", + "banner": { + "w": 300, + "h": 250 + }, + "secure": 1, + "ext": { + "tid": "${json-unit.any-string}", + "bidder": { + "partnerCode": "test-partner", + "token": "test-token" + } + } + } + ], + "site": { + "domain": "www.example.com", + "page": "http://www.example.com", + "publisher": { + "domain": "example.com" + }, + "ext": { + "amp": 0 + } + }, + "device": { + "ua": "userAgent", + "ip": "193.168.244.1" + }, + "at": 1, + "tmax": "${json-unit.any-number}", + "cur": [ + "USD" + ], + "source": { + "tid": "${json-unit.any-string}" + }, + "regs": { + "gdpr": 0 + }, + "ext": { + "prebid": { + "server": { + "externalurl": "http://localhost:8080", + "gvlid": 1, + "datacenter": "local", + "http_method": "POST", + "endpoint": "/openrtb2/auction" + } + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-sellwild-bid-response.json b/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-sellwild-bid-response.json new file mode 100644 index 00000000000..fae9d3c4ae2 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/sellwild/test-sellwild-bid-response.json @@ -0,0 +1,21 @@ +{ + "id": "request_id", + "seatbid": [ + { + "bid": [ + { + "id": "bid_id", + "impid": "imp_id", + "price": 3.33, + "adm": "adm001", + "crid": "crid", + "w": 300, + "h": 250, + "mtype": 1 + } + ], + "seat": "sellwild" + } + ], + "cur": "USD" +} diff --git a/src/test/resources/org/prebid/server/it/test-application.properties b/src/test/resources/org/prebid/server/it/test-application.properties index 151edf4395a..2b7c9cc0bcd 100644 --- a/src/test/resources/org/prebid/server/it/test-application.properties +++ b/src/test/resources/org/prebid/server/it/test-application.properties @@ -537,6 +537,8 @@ adapters.seedingAlliance.aliases.finative.enabled=true adapters.seedingAlliance.aliases.finative.endpoint=http://localhost:8090/finative-exchange adapters.seedtag.enabled=true adapters.seedtag.endpoint=http://localhost:8090/seedtag-exchange +adapters.sellwild.enabled=true +adapters.sellwild.endpoint=http://localhost:8090/sellwild-exchange/{PublisherId} adapters.sevio.enabled=true adapters.sevio.endpoint=http://localhost:8090/sevio-exchange adapters.smaato.enabled=true From 2ff05c0cd4c17121485f706b9c7413b06291d46e Mon Sep 17 00:00:00 2001 From: Nick Pirollo Date: Mon, 9 Nov 2026 16:00:50 -0800 Subject: [PATCH 2/3] Sellwild: use support@sellwild.com as maintainer contact --- src/main/resources/bidder-config/sellwild.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/bidder-config/sellwild.yaml b/src/main/resources/bidder-config/sellwild.yaml index c1937277078..3efe50f73d4 100644 --- a/src/main/resources/bidder-config/sellwild.yaml +++ b/src/main/resources/bidder-config/sellwild.yaml @@ -3,7 +3,7 @@ adapters: endpoint: https://exchange.sellwild.com/exchange/openrtb2/{PublisherId} ortb-version: "2.6" meta-info: - maintainer-email: prebid@sellwild.com + maintainer-email: support@sellwild.com app-media-types: - banner - video From bf901db44536474c071bad850e5a5110e6a2493d Mon Sep 17 00:00:00 2001 From: Nick Pirollo Date: Mon, 9 Nov 2026 18:12:25 -0800 Subject: [PATCH 3/3] Sellwild: split requests by token and disable bidder debug The exchange authenticates a request with its first imp token, so imps that share a partner code but carry different tokens now go out as separate requests. Bidder debug is disabled because the token travels in imp.ext.bidder. --- .../bidder/sellwild/SellwildBidder.java | 10 +++++--- .../resources/bidder-config/sellwild.yaml | 3 +++ .../bidder/sellwild/SellwildBidderTest.java | 25 ++++++++++++++++++- 3 files changed, 33 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/prebid/server/bidder/sellwild/SellwildBidder.java b/src/main/java/org/prebid/server/bidder/sellwild/SellwildBidder.java index 22463fb5194..5d3de19d82b 100644 --- a/src/main/java/org/prebid/server/bidder/sellwild/SellwildBidder.java +++ b/src/main/java/org/prebid/server/bidder/sellwild/SellwildBidder.java @@ -55,20 +55,22 @@ public SellwildBidder(String endpointUrl, JacksonMapper mapper) { @Override public Result>> makeHttpRequests(BidRequest request) { final List errors = new ArrayList<>(); - final Map> partnerCodeToImps = new LinkedHashMap<>(); + // The exchange authenticates a request with the token of its first imp, so imps are only + // grouped when they share both partner code and token. + final Map> paramsToImps = new LinkedHashMap<>(); for (Imp imp : request.getImp()) { try { final ExtImpSellwild extImp = parseImpExt(imp); validateImpExt(extImp, imp.getId()); - partnerCodeToImps.computeIfAbsent(extImp.getPartnerCode(), key -> new ArrayList<>()).add(imp); + paramsToImps.computeIfAbsent(extImp, key -> new ArrayList<>()).add(imp); } catch (PreBidException e) { errors.add(BidderError.badInput(e.getMessage())); } } - final List> httpRequests = partnerCodeToImps.entrySet().stream() - .map(entry -> makeHttpRequest(request, entry.getKey(), entry.getValue())) + final List> httpRequests = paramsToImps.entrySet().stream() + .map(entry -> makeHttpRequest(request, entry.getKey().getPartnerCode(), entry.getValue())) .toList(); return Result.of(httpRequests, errors); diff --git a/src/main/resources/bidder-config/sellwild.yaml b/src/main/resources/bidder-config/sellwild.yaml index 3efe50f73d4..ea372b58e28 100644 --- a/src/main/resources/bidder-config/sellwild.yaml +++ b/src/main/resources/bidder-config/sellwild.yaml @@ -2,6 +2,9 @@ adapters: sellwild: endpoint: https://exchange.sellwild.com/exchange/openrtb2/{PublisherId} ortb-version: "2.6" + # The partner token travels in imp.ext.bidder, so keep the outbound request out of debug output. + debug: + allow: false meta-info: maintainer-email: support@sellwild.com app-media-types: diff --git a/src/test/java/org/prebid/server/bidder/sellwild/SellwildBidderTest.java b/src/test/java/org/prebid/server/bidder/sellwild/SellwildBidderTest.java index 69957b1bfea..191374aa021 100644 --- a/src/test/java/org/prebid/server/bidder/sellwild/SellwildBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/sellwild/SellwildBidderTest.java @@ -116,7 +116,7 @@ public void makeHttpRequestsShouldGroupImpsByPartnerCodePreservingOrder() { final BidRequest bidRequest = givenBidRequest( givenImp(imp -> imp.id("imp1"), ExtImpSellwild.of("partnerB", "token1")), givenImp(imp -> imp.id("imp2"), ExtImpSellwild.of("partnerA", "token2")), - givenImp(imp -> imp.id("imp3"), ExtImpSellwild.of("partnerB", "token3"))); + givenImp(imp -> imp.id("imp3"), ExtImpSellwild.of("partnerB", "token1"))); // when final Result>> result = target.makeHttpRequests(bidRequest); @@ -136,6 +136,29 @@ public void makeHttpRequestsShouldGroupImpsByPartnerCodePreservingOrder() { }); } + @Test + public void makeHttpRequestsShouldSplitImpsWithSamePartnerCodeAndDifferentTokens() { + // given + final BidRequest bidRequest = givenBidRequest( + givenImp(imp -> imp.id("imp1"), ExtImpSellwild.of("partner", "token1")), + givenImp(imp -> imp.id("imp2"), ExtImpSellwild.of("partner", "token2"))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).satisfiesExactly( + request -> { + assertThat(request.getUri()).isEqualTo("https://test.endpoint.com/openrtb2/partner"); + assertThat(request.getPayload().getImp()).extracting(Imp::getId).containsExactly("imp1"); + }, + request -> { + assertThat(request.getUri()).isEqualTo("https://test.endpoint.com/openrtb2/partner"); + assertThat(request.getPayload().getImp()).extracting(Imp::getId).containsExactly("imp2"); + }); + } + @Test public void makeHttpRequestsShouldEscapePartnerCodeInUrl() { // given