From 2d959cad26039383665d53ee79715b7c2c2bb462 Mon Sep 17 00:00:00 2001 From: Russell McGuire Date: Mon, 26 Oct 2026 15:38:33 -0700 Subject: [PATCH] Rename abi check rule to make sense Old rule appeared as skipped and was misleading with it's name so renaming it to not look invalid Signed-off-by: Russell McGuire --- .github/workflows/check-abi.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check-abi.yml b/.github/workflows/check-abi.yml index 49577b4f..76b1b519 100644 --- a/.github/workflows/check-abi.yml +++ b/.github/workflows/check-abi.yml @@ -23,7 +23,10 @@ jobs: # A failure can be accepted by a reviewer: leave an approval review on the # PR head commit with the keyword abi-failure-approved in the review body. check-abi: - name: check-abi-${{ matrix.base }} + # The name must not use matrix: a skipped job shows its name unexpanded. + # GitHub appends the matrix value, e.g. "check-abi (master)". Reviews + # without the keyword skip this job and show "ABI approval re-check". + name: ${{ github.event_name == 'pull_request_review' && 'ABI approval re-check' || 'check-abi' }} runs-on: ubuntu-latest if: >- github.repository_owner == 'oneapi-src' &&