From e341598f66d930bb5a15568482e41b66f2023d28 Mon Sep 17 00:00:00 2001 From: Peter Willendrup Date: Sun, 15 Nov 2026 21:00:15 +0100 Subject: [PATCH] mccode-complex-lib: make the wrappers static inline Plain C99 inline has no external definition, so the link fails with "undefined reference to cmul" whenever the compiler does not inline a call (e.g. at -O0, or Phonon_BvK_PG's eigen solver with clang on Ubuntu). Co-Authored-By: Claude Opus 5.5 --- common/lib/share/mccode-complex-lib.h | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/common/lib/share/mccode-complex-lib.h b/common/lib/share/mccode-complex-lib.h index c99e3e9b7b..94ece28389 100644 --- a/common/lib/share/mccode-complex-lib.h +++ b/common/lib/share/mccode-complex-lib.h @@ -30,25 +30,25 @@ // Note: leave two spaces between double and cdouble because double->float // in generate._convert_type is not clever enough. typedef complex double cdouble; -inline cdouble cplx(const double x, const double y) { return x + y*I; } -inline cdouble cneg(const cdouble a) { return -a; } -inline cdouble radd(const double a, const cdouble b) { return a+b; } -inline cdouble rmul(const double a, const cdouble b) { return a*b; } -inline cdouble cadd(const cdouble a, const cdouble b) { return a+b; } -inline cdouble csub(const cdouble a, const cdouble b) { return a-b; } -inline cdouble cmul(const cdouble a, const cdouble b) { return a*b; } -inline cdouble cdiv(const cdouble a, const cdouble b) { return a/b; } +static inline cdouble cplx(const double x, const double y) { return x + y*I; } +static inline cdouble cneg(const cdouble a) { return -a; } +static inline cdouble radd(const double a, const cdouble b) { return a+b; } +static inline cdouble rmul(const double a, const cdouble b) { return a*b; } +static inline cdouble cadd(const cdouble a, const cdouble b) { return a+b; } +static inline cdouble csub(const cdouble a, const cdouble b) { return a-b; } +static inline cdouble cmul(const cdouble a, const cdouble b) { return a*b; } +static inline cdouble cdiv(const cdouble a, const cdouble b) { return a/b; } #else // MSVC typedef _Dcomplex cdouble; -inline cdouble cplx(const double x, const double y) { cdouble z = _Cbuild(x,y); return z; } -inline cdouble cneg(const cdouble a) { return cplx( -creal(a) , -cimag(a) ); } -inline cdouble radd(const double a, const cdouble b) { return cplx(a+creal(b),cimag(b)); } -inline cdouble rmul(const double a, const cdouble b) { return cplx(a*creal(b),a*cimag(b)); } -inline cdouble cadd(const cdouble a, const cdouble b) { return cplx(creal(a)+creal(b),cimag(a)+cimag(b)); } -inline cdouble csub(const cdouble a, const cdouble b) { return cplx(creal(a)-creal(b),cimag(a)-cimag(b)); } -inline cdouble cmul(const cdouble a, const cdouble b) { return cplx(creal(a)*creal(b) - cimag(a)*cimag(b), cimag(a)*creal(b) + creal(a)*cimag(b)); } -inline cdouble cdiv(const cdouble a, const cdouble b) { return cplx((creal(a)*creal(b)+cimag(a)*cimag(b))/(creal(b)*creal(b)+cimag(b)*cimag(b)),(cimag(a)*creal(b)-creal(a)*cimag(b))/(creal(b)*creal(b)+cimag(b)*cimag(b))); } +static inline cdouble cplx(const double x, const double y) { cdouble z = _Cbuild(x,y); return z; } +static inline cdouble cneg(const cdouble a) { return cplx( -creal(a) , -cimag(a) ); } +static inline cdouble radd(const double a, const cdouble b) { return cplx(a+creal(b),cimag(b)); } +static inline cdouble rmul(const double a, const cdouble b) { return cplx(a*creal(b),a*cimag(b)); } +static inline cdouble cadd(const cdouble a, const cdouble b) { return cplx(creal(a)+creal(b),cimag(a)+cimag(b)); } +static inline cdouble csub(const cdouble a, const cdouble b) { return cplx(creal(a)-creal(b),cimag(a)-cimag(b)); } +static inline cdouble cmul(const cdouble a, const cdouble b) { return cplx(creal(a)*creal(b) - cimag(a)*cimag(b), cimag(a)*creal(b) + creal(a)*cimag(b)); } +static inline cdouble cdiv(const cdouble a, const cdouble b) { return cplx((creal(a)*creal(b)+cimag(a)*cimag(b))/(creal(b)*creal(b)+cimag(b)*cimag(b)),(cimag(a)*creal(b)-creal(a)*cimag(b))/(creal(b)*creal(b)+cimag(b)*cimag(b))); } #endif #endif