From aa91a9b72b80731cfe6e3071e8b31ad5c62658cd Mon Sep 17 00:00:00 2001 From: Albert Hsieh Date: Thu, 5 Nov 2026 22:08:41 +0800 Subject: [PATCH] fix(translation): preserve latest language selection during async loads --- DynamicTranslation.js | 6 ++- tests/language-race.test.js | 92 +++++++++++++++++++++++++++++++++++++ 2 files changed, 97 insertions(+), 1 deletion(-) create mode 100644 tests/language-race.test.js diff --git a/DynamicTranslation.js b/DynamicTranslation.js index b6de725..1fbfcf0 100644 --- a/DynamicTranslation.js +++ b/DynamicTranslation.js @@ -94,6 +94,7 @@ // TranslationManager 類別 - 支援 mtool 工具的 key-value 格式 var TranslationManager = function () { this._currentLanguage = defaultLanguage; + this._languageRequest = null; this._translations = {}; // key-value 格式的翻譯字典 this._originalTexts = {}; // 記錄原文的映射 this._isInitialized = false; @@ -205,11 +206,14 @@ // 設定當前語言 TranslationManager.prototype.setLanguage = function (language) { + // Every selection supersedes pending loads, including reselecting the active language. + var request = {}; + this._languageRequest = request; if (this._currentLanguage === language) return; if (!this._translations[language]) { this.loadLanguage(language, function (success) { - if (success) { + if (success && this._languageRequest === request) { this._currentLanguage = language; this._applyTranslations(); this._refreshAllWindows(); diff --git a/tests/language-race.test.js b/tests/language-race.test.js new file mode 100644 index 0000000..5e7aa00 --- /dev/null +++ b/tests/language-race.test.js @@ -0,0 +1,92 @@ +require('./setup'); + +describe('asynchronous language selection', () => { + let tm; + let pending; + + beforeAll(() => global.loadPlugin()); + beforeEach(() => { + tm = new window.TranslationManager(); + tm._isInitialized = true; + tm._translations.zh = { Level: '等級' }; + tm._applyTranslations = jest.fn(); + tm._refreshAllWindows = jest.fn(); + pending = []; + jest.spyOn(XMLHttpRequest.prototype, 'send').mockImplementation(function () { + pending.push(this); + }); + }); + afterEach(() => jest.restoreAllMocks()); + + function complete(index, success = true) { + const xhr = pending[index]; + xhr.status = success ? 200 : 404; + xhr.responseText = JSON.stringify({ Level: xhr.url }); + xhr.onload(); + } + + test('the latest uncached selection wins even when responses arrive backwards', () => { + tm.setLanguage('en'); + tm.setLanguage('ja'); + complete(1); + complete(0); + expect(tm.getCurrentLanguage()).toBe('ja'); + expect(tm.translate('Level')).toBe('translations/ja.json'); + expect(tm._refreshAllWindows).toHaveBeenCalledTimes(1); + expect(tm._translations.en).toBeDefined(); + }); + + test('an older completion does not temporarily apply while the latest is pending', () => { + tm.setLanguage('en'); + tm.setLanguage('ja'); + complete(0); + expect(tm.getCurrentLanguage()).toBe('zh'); + expect(tm._applyTranslations).not.toHaveBeenCalled(); + complete(1); + expect(tm.getCurrentLanguage()).toBe('ja'); + }); + + test('selecting the current language cancels an outstanding selection', () => { + tm.setLanguage('en'); + tm.setLanguage('zh'); + complete(0); + expect(tm.getCurrentLanguage()).toBe('zh'); + expect(tm._refreshAllWindows).not.toHaveBeenCalled(); + }); + + test('a cached selection supersedes an outstanding load', () => { + tm._translations.ja = { Level: 'レベル' }; + tm.setLanguage('en'); + tm.setLanguage('ja'); + complete(0); + expect(tm.getCurrentLanguage()).toBe('ja'); + expect(tm.translate('Level')).toBe('レベル'); + expect(tm._refreshAllWindows).toHaveBeenCalledTimes(1); + }); + + test('a failed latest selection preserves the active language, not an older request', () => { + tm.setLanguage('en'); + tm.setLanguage('ja'); + complete(1, false); + complete(0); + expect(tm.getCurrentLanguage()).toBe('zh'); + expect(tm._refreshAllWindows).not.toHaveBeenCalled(); + }); + + test('a single successful selection still applies and refreshes', () => { + tm.setLanguage('en'); + complete(0); + expect(tm.getCurrentLanguage()).toBe('en'); + expect(tm._applyTranslations).toHaveBeenCalledTimes(1); + expect(tm._refreshAllWindows).toHaveBeenCalledTimes(1); + }); + + test('a failed selection can be retried', () => { + tm.setLanguage('en'); + complete(0, false); + tm.setLanguage('en'); + complete(1); + expect(tm.getCurrentLanguage()).toBe('en'); + expect(tm._refreshAllWindows).toHaveBeenCalledTimes(1); + }); +});