From eab0a9c919e815111e39db33c7af53b3f6b74cd1 Mon Sep 17 00:00:00 2001 From: Tony Mountifield Date: Wed, 11 Nov 2026 19:25:57 +0000 Subject: [PATCH 1/2] Use ubuntu-24 in coding style check --- .github/workflows/coding-style-check.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/coding-style-check.yml b/.github/workflows/coding-style-check.yml index d06bfd7b3c..0dbeb00e40 100644 --- a/.github/workflows/coding-style-check.yml +++ b/.github/workflows/coding-style-check.yml @@ -34,7 +34,7 @@ jobs: # As this action runs with minimal permissions and does not influence the build output, # we perform no version pinning for the runner or the installed tools here. # The clangFormatVersion is based on Ubuntu current LTS (jammy at time of writing). - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v7 - name: Check .cpp/.h/.mm with clang-format @@ -47,7 +47,7 @@ jobs: check-bash-style: name: Verify shell script (Bash) coding style - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 # shellcheck is already pre-installed on ubuntu-latest steps: - uses: actions/checkout@v7 @@ -60,7 +60,7 @@ jobs: check-python-style: name: Verify Python coding style - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v7 - name: Install pylint From 15936c954db7be6f573bbef0a4a3bce1fbd83a4b Mon Sep 17 00:00:00 2001 From: Tony Mountifield Date: Thu, 12 Nov 2026 12:51:26 +0000 Subject: [PATCH 2/2] Fetch shfmt from apt instead of snap --- .github/workflows/coding-style-check.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/coding-style-check.yml b/.github/workflows/coding-style-check.yml index 0dbeb00e40..2321d31f96 100644 --- a/.github/workflows/coding-style-check.yml +++ b/.github/workflows/coding-style-check.yml @@ -53,8 +53,10 @@ jobs: - uses: actions/checkout@v7 - name: Check .sh with shellcheck run: find -name '*.sh' -not -path './libs/*' -exec shellcheck --shell=bash {} + + - name: Update package index + run: sudo apt-get update - name: Install shfmt - run: sudo snap install shfmt + run: sudo apt-get -qq install shfmt - name: Check .sh with shfmt run: shfmt -d .