From e3ec188afda5cf8c77300ac4b5c07065e8d09ff3 Mon Sep 17 00:00:00 2001 From: Sylvie Paindeville Date: Thu, 29 Oct 2026 18:03:27 +0100 Subject: [PATCH 1/3] Fix template substitution for boolean default false. assignTemplates treated false as missing when filling placeholders, which broke SET DEFAULT false in separate FE statements. Co-authored-by: Cursor --- forward_engineering/utils/assignTemplates.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/forward_engineering/utils/assignTemplates.js b/forward_engineering/utils/assignTemplates.js index 4b32a2a..faadeef 100644 --- a/forward_engineering/utils/assignTemplates.js +++ b/forward_engineering/utils/assignTemplates.js @@ -16,7 +16,11 @@ const assignTemplates = (str, templates) => { const templateName = parseTemplate(item); return result.replace(item, () => { - return templates[templateName] || templates[templateName] === 0 ? templates[templateName] : ''; + const value = templates[templateName]; + if (value === undefined || value === null) { + return ''; + } + return value; }); }, str); }; From 381091a232c9603d52034bf8c870ebfc7463d510 Mon Sep 17 00:00:00 2001 From: Sylvie Paindeville Date: Thu, 29 Oct 2026 18:16:14 +0100 Subject: [PATCH 2/3] Fix inline and separate defaults when boolean default is false. getColumnDefault skipped false because of a truthy check; extend the same handling as assignTemplates. Co-authored-by: Cursor --- .../ddlHelpers/columnDefinitionHelpers/getColumnDefault.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/forward_engineering/ddlProvider/ddlHelpers/columnDefinitionHelpers/getColumnDefault.js b/forward_engineering/ddlProvider/ddlHelpers/columnDefinitionHelpers/getColumnDefault.js index de6ccfa..6170183 100644 --- a/forward_engineering/ddlProvider/ddlHelpers/columnDefinitionHelpers/getColumnDefault.js +++ b/forward_engineering/ddlProvider/ddlHelpers/columnDefinitionHelpers/getColumnDefault.js @@ -85,7 +85,7 @@ const getColumnDefault = ({ type, default: defaultValue, defaultOnNull, generate return `${generatedClause} AS (${expressionValue})`; } - if (defaultValue || defaultValue === 0) { + if (defaultValue === false || defaultValue === true || defaultValue || defaultValue === 0) { const onNull = getOnNullClause({ onNull: defaultOnNull }); return ` DEFAULT${onNull} ${defaultValue}`; From b753d8b05ab22987c5c4333194b1fc3ba2048629 Mon Sep 17 00:00:00 2001 From: Sylvie Paindeville <146110625+Sylvie-P@users.noreply.github.com> Date: Fri, 30 Oct 2026 09:35:03 +0100 Subject: [PATCH 3/3] Apply suggestion from @taras-dubyk Co-authored-by: Taras Dubyk --- .../ddlHelpers/columnDefinitionHelpers/getColumnDefault.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/forward_engineering/ddlProvider/ddlHelpers/columnDefinitionHelpers/getColumnDefault.js b/forward_engineering/ddlProvider/ddlHelpers/columnDefinitionHelpers/getColumnDefault.js index 6170183..9ba4ac5 100644 --- a/forward_engineering/ddlProvider/ddlHelpers/columnDefinitionHelpers/getColumnDefault.js +++ b/forward_engineering/ddlProvider/ddlHelpers/columnDefinitionHelpers/getColumnDefault.js @@ -85,7 +85,7 @@ const getColumnDefault = ({ type, default: defaultValue, defaultOnNull, generate return `${generatedClause} AS (${expressionValue})`; } - if (defaultValue === false || defaultValue === true || defaultValue || defaultValue === 0) { + if (defaultValue !== undefined && defaultValue !== null) { const onNull = getOnNullClause({ onNull: defaultOnNull }); return ` DEFAULT${onNull} ${defaultValue}`;