From ae472a9b57c5a5a3a51cd9d53612c6bd84f34b44 Mon Sep 17 00:00:00 2001 From: Alex Andres Date: Fri, 20 Nov 2026 19:43:28 +0100 Subject: [PATCH] test: accept prflx for direct connections in candidate type checks On a host with a bridge, such as Docker's, the answer to a check can name another local address, which WebRTC takes as a peer-reflexive local candidate. statsAfterConnecting failed about one run in three that way. --- .../test/java/dev/onvoid/webrtc/client/CallCheckTests.java | 3 ++- webrtc/src/test/java/dev/onvoid/webrtc/client/PeerTests.java | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/webrtc/src/test/java/dev/onvoid/webrtc/client/CallCheckTests.java b/webrtc/src/test/java/dev/onvoid/webrtc/client/CallCheckTests.java index 09181997e..d37545295 100644 --- a/webrtc/src/test/java/dev/onvoid/webrtc/client/CallCheckTests.java +++ b/webrtc/src/test/java/dev/onvoid/webrtc/client/CallCheckTests.java @@ -210,7 +210,8 @@ void connectsToTestPeer() throws Exception { assertNotNull(result.network().connectTime()); assertNull(result.network().failure()); assertFalse(result.network().isRelayed()); - assertEquals("host", result.network().candidateType()); + // Direct; prflx where the host has a bridge, as in PeerTests. + assertTrue(Arrays.asList("host", "prflx").contains(result.network().candidateType()), result::toString); // The check's own peer is closed, the test peer is the application's. assertEquals(Collections.singletonList(testPeer), rtc.peers()); diff --git a/webrtc/src/test/java/dev/onvoid/webrtc/client/PeerTests.java b/webrtc/src/test/java/dev/onvoid/webrtc/client/PeerTests.java index d7a69c3e5..5f881580e 100644 --- a/webrtc/src/test/java/dev/onvoid/webrtc/client/PeerTests.java +++ b/webrtc/src/test/java/dev/onvoid/webrtc/client/PeerTests.java @@ -656,7 +656,10 @@ void statsAfterConnecting() throws Exception { PeerStats first = await(peers[0].stats()); PeerStats second = await(peers[0].stats()); - assertEquals("host", first.candidateType()); + // Direct, but not always host: on a machine with a bridge, such as + // Docker's, the answer to a check may name another local address, + // which WebRTC then takes as a peer-reflexive candidate. + assertTrue(Arrays.asList("host", "prflx").contains(first.candidateType()), first::toString); assertTrue(first.bytesSent() > 10_000, () -> "Bytes sent: " + first.bytesSent()); assertEquals(first.report().getTimestamp(), ChronoUnit.MICROS.between(Instant.EPOCH, first.timestamp())); assertEquals(-1, first.outgoingBitrate());