From ef767805378ec4c6df477e54c493fe9c670b2585 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Thu, 5 Nov 2026 15:42:55 -0500 Subject: [PATCH 1/4] Add GitHub Actions workflow for codespell on master --- .github/workflows/codespell.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/codespell.yml diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml new file mode 100644 index 00000000..9458b0c8 --- /dev/null +++ b/.github/workflows/codespell.yml @@ -0,0 +1,23 @@ +# Codespell configuration is within .codespellrc +--- +name: Codespell + +on: + push: + branches: [master] + pull_request: + branches: [master] + +permissions: + contents: read + +jobs: + codespell: + name: Check for spelling errors + runs-on: ubuntu-latest + + steps: + - name: Checkout + uses: actions/checkout@v6 + - name: Codespell + uses: codespell-project/actions-codespell@8f01853be192eb0f849a5c7d721450e7a467c579 # v2.2 From 671a996c2f027f99d90e131087a676d5517d5903 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Thu, 5 Nov 2026 15:42:55 -0500 Subject: [PATCH 2/4] Add rudimentary codespell config --- .codespellrc | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .codespellrc diff --git a/.codespellrc b/.codespellrc new file mode 100644 index 00000000..e44368cd --- /dev/null +++ b/.codespellrc @@ -0,0 +1,6 @@ +[codespell] +# Ref: https://github.com/codespell-project/codespell#using-a-config-file +skip = .git,.gitignore,.gitattributes,go.sum,.codespellrc +check-hidden = true +# ignore-regex = +# ignore-words-list = From cd49ffc35eba84570ee7707e290a980b1d21287c Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Thu, 5 Nov 2026 15:42:58 -0500 Subject: [PATCH 3/4] [DATALAD RUNCMD] chore: run codespell throughout fixing few left typos automagically === Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ --- README.md | 2 +- doc/intro.md | 2 +- doc/langdef.md | 2 +- proto/cel/expr/syntax.proto | 2 +- tests/simple/testdata/macros.textproto | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index f3bcbe4b..5759b71a 100644 --- a/README.md +++ b/README.md @@ -42,7 +42,7 @@ The required components of a system that supports CEL are: * An evaluator library that takes the binary format in the context and produces a result, usually a Boolean. -For use cases which require persistence or cross-process communcation, it is +For use cases which require persistence or cross-process communication, it is highly recommended to serialize the type-checked expression as a protocol buffer. The CEL team will maintains canonical protocol buffers for ASTs and will keep these versions identical and wire-compatible in perpetuity: diff --git a/doc/intro.md b/doc/intro.md index 61354fd8..0f46f3cc 100644 --- a/doc/intro.md +++ b/doc/intro.md @@ -35,7 +35,7 @@ matches(account.phone_number, "[0-9-]+") // true if number matches regexp ``` CEL expressions support most operators and functions one would expect when -working with protocol buffers: boolean operators, relations, arithmetics on +working with protocol buffers: boolean operators, relations, arithmetic on numbers, string and byte string operations, and operations to deal with lists and maps. The full reference of standard operations is described in the [language definition](langdef.md#standard). Note that applications of CEL may add diff --git a/doc/langdef.md b/doc/langdef.md index bcce828c..94bade14 100644 --- a/doc/langdef.md +++ b/doc/langdef.md @@ -398,7 +398,7 @@ represented during static type checking. A CEL implementation can add new types to the language. These types will be given names in the same namespace as the other types, but will have no special support in the language syntax. The only way to construct or use values of these -abstract types is through functions which the implementor must also provide. +abstract types is through functions which the implementer must also provide. Commonly, an abstract type will have a representation as a protocol buffer, so that it can be stored or transmitted across a network. In this case, the diff --git a/proto/cel/expr/syntax.proto b/proto/cel/expr/syntax.proto index 00635e66..f977aabf 100644 --- a/proto/cel/expr/syntax.proto +++ b/proto/cel/expr/syntax.proto @@ -102,7 +102,7 @@ message Expr { // A list creation expression. // - // Lists may either be homogenous, e.g. `[1, 2, 3]`, or heterogeneous, e.g. + // Lists may either be homogeneous, e.g. `[1, 2, 3]`, or heterogeneous, e.g. // `dyn([1, 'hello', 2.0])` message CreateList { // The elements part of the list. diff --git a/tests/simple/testdata/macros.textproto b/tests/simple/testdata/macros.textproto index 26a201fa..e3fbe2c0 100644 --- a/tests/simple/testdata/macros.textproto +++ b/tests/simple/testdata/macros.textproto @@ -29,7 +29,7 @@ section { } test { name: "list_elem_type_exhaustive" - description: "Exists filter is never true, but heterogenous equality ensure the result is false." + description: "Exists filter is never true, but heterogeneous equality ensure the result is false." expr: "[1, 'foo', 3].exists(e, e == '10')" value: { bool_value: false } } From aed260d7859b57af67541c5025bf3d8dc334bb38 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Thu, 5 Nov 2026 15:45:04 -0500 Subject: [PATCH 4/4] Skip .git-meta and tool caches, protect URLs in codespell config codespell walks the working tree, not just tracked files, so untracked tool caches (.*cache) and local message drafts (.git-meta) would otherwise be checked. Ignore URLs since a typo in one is still the working link and must not be rewritten by codespell -w. --- .codespellrc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.codespellrc b/.codespellrc index e44368cd..be11f83d 100644 --- a/.codespellrc +++ b/.codespellrc @@ -1,6 +1,7 @@ [codespell] # Ref: https://github.com/codespell-project/codespell#using-a-config-file -skip = .git,.gitignore,.gitattributes,go.sum,.codespellrc +skip = .git,.git-meta,.gitignore,.gitattributes,.*cache,go.sum,.codespellrc check-hidden = true -# ignore-regex = +# Do not "fix" URLs: a typo in a URL is still the working link +ignore-regex = https?://\S+ # ignore-words-list =