From 3d888097c17dbe47b223419aef486bd2d438ee82 Mon Sep 17 00:00:00 2001 From: Matt Raible Date: Sat, 14 Nov 2026 16:51:02 -0700 Subject: [PATCH] Put form labels above their fields and line up the entry editor's status row The admin forms put each label in a column beside its field. A short label such as Title sat a long way from its input, and long ones such as "Email address of weblog owner" wrapped onto two lines and made their rows taller than the rest. Labels now sit above their fields at every width, as they already did on narrow screens: every label fits on one line, fields use the full width, and rows whose first column was an empty label, there only to indent a checkbox, lose the indent. On the entry editor, the Permalink and Status rows were hand-written and out of step with the generated rows around them. Their labels lacked col-form-label, so they were regular weight; the values were wrapped in a paragraph that added a top margin; and the status used Bootstrap 3's label class, which Bootstrap 5 renders as plain coloured text with no padding. They now use the same label classes as the other rows, a div for the value, and Bootstrap 5's badge. The Status label also pointed at an id that does not exist. Checked on 22 admin pages with 115 form rows: none is left side by side and none overflows. --- CHANGES.md | 7 +++++ .../webapp/WEB-INF/jsps/editor/EntryEdit.jsp | 26 +++++++++---------- .../main/webapp/roller-ui/styles/roller.css | 24 +++++++++++++++++ 3 files changed, 44 insertions(+), 13 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 3144129598..36a9ec5357 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -45,6 +45,13 @@ - The default blogroll can't be renamed, since themes find it by its name, and the page works on phones. +- **Form labels sit above their fields.** In the admin forms a label used to + sit in a column beside its field, so short labels were a long way from + their inputs and long ones wrapped onto two lines. Labels are now above + their fields at every width, as they already were on phones. On the entry + editor, the Permalink and Status rows line up with the rest and the status + is shown as a badge. + ### Bug fixes - **A bad date pattern in a theme no longer blanks the page.** diff --git a/app/src/main/webapp/WEB-INF/jsps/editor/EntryEdit.jsp b/app/src/main/webapp/WEB-INF/jsps/editor/EntryEdit.jsp index e93b76ded7..cdefe9108d 100644 --- a/app/src/main/webapp/WEB-INF/jsps/editor/EntryEdit.jsp +++ b/app/src/main/webapp/WEB-INF/jsps/editor/EntryEdit.jsp @@ -67,12 +67,12 @@
-