From f98a0c56f41208f41eb1e15dbe75da662b854b3e Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Tue, 3 Nov 2026 06:57:18 +0100 Subject: [PATCH 01/17] Deploy whole installation via ant maven-install --- nbbuild/build.xml | 57 ++++++++++++++++++++++++++++--- nbbuild/default-properties.xml | 9 +++++ nbbuild/templates/projectized.xml | 3 +- 3 files changed, 63 insertions(+), 6 deletions(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index 7fe00ca5b472..816348fe1d23 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -319,8 +319,7 @@ metabuild.hash=${metabuild.hash} - - + @@ -331,8 +330,7 @@ metabuild.hash=${metabuild.hash} - - + @@ -415,6 +413,57 @@ metabuild.hash=${metabuild.hash} + + + + + + + + + + + + + + + + + + diff --git a/nbbuild/default-properties.xml b/nbbuild/default-properties.xml index 88ce933b8d3a..ff9796795098 100644 --- a/nbbuild/default-properties.xml +++ b/nbbuild/default-properties.xml @@ -46,10 +46,19 @@ + + + + + + diff --git a/nbbuild/templates/projectized.xml b/nbbuild/templates/projectized.xml index bdd324ce7478..b3bd2931f5d5 100644 --- a/nbbuild/templates/projectized.xml +++ b/nbbuild/templates/projectized.xml @@ -896,7 +896,6 @@ - @@ -928,7 +927,7 @@ - + From 768a4a8458f53dd013a3129d4b57d09ef2087476 Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Tue, 3 Nov 2026 07:17:02 +0100 Subject: [PATCH 02/17] Provide additional arguments via mavenArgs property --- nbbuild/build.xml | 6 +++--- nbbuild/templates/projectized.xml | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index 816348fe1d23..869b120e3347 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -451,7 +451,7 @@ metabuild.hash=${metabuild.hash} zip zipFile:'mavenrepo.zip',dir:'mavenrepository',archive:'true' --> - + @@ -460,9 +460,9 @@ metabuild.hash=${metabuild.hash} - + - + diff --git a/nbbuild/templates/projectized.xml b/nbbuild/templates/projectized.xml index b3bd2931f5d5..21db77d29de9 100644 --- a/nbbuild/templates/projectized.xml +++ b/nbbuild/templates/projectized.xml @@ -918,6 +918,7 @@ + @@ -929,6 +930,7 @@ - + + From 809f263701b07c7ad02e3ff6486f69776683bbd0 Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Tue, 3 Nov 2026 08:48:52 +0100 Subject: [PATCH 03/17] Fail the build Ant build on Maven error --- nbbuild/build.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index 869b120e3347..44eb197eed8f 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -452,7 +452,7 @@ metabuild.hash=${metabuild.hash} zip zipFile:'mavenrepo.zip',dir:'mavenrepository',archive:'true' --> - + From 53efb65d20ecf671dd90d3b5533c423df5834b84 Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Wed, 4 Nov 2026 06:02:20 +0100 Subject: [PATCH 04/17] Expose Maven Install in the UI --- nbbuild/build.xml | 1 + nbbuild/nbproject/project.xml | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index 44eb197eed8f..b39f35f63ee0 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -461,6 +461,7 @@ metabuild.hash=${metabuild.hash} + diff --git a/nbbuild/nbproject/project.xml b/nbbuild/nbproject/project.xml index 976d1a4e0fe3..b8fe340604ef 100644 --- a/nbbuild/nbproject/project.xml +++ b/nbbuild/nbproject/project.xml @@ -188,6 +188,10 @@ build-nozip + + + maven-install + clean @@ -196,10 +200,6 @@ commit-validation - - - -Dname=apisupport rebuild-cluster - From adf8ca0b95c5dfb523aa9e8b59a1c534b8f3f91b Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Wed, 4 Nov 2026 06:20:41 +0100 Subject: [PATCH 05/17] Prefixing the properties with nbm. --- nbbuild/build.xml | 8 ++++---- nbbuild/default-properties.xml | 6 ++++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index b39f35f63ee0..e75675f9163f 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -453,17 +453,17 @@ metabuild.hash=${metabuild.hash} --> - + - - + + - + diff --git a/nbbuild/default-properties.xml b/nbbuild/default-properties.xml index ff9796795098..2393fb975947 100644 --- a/nbbuild/default-properties.xml +++ b/nbbuild/default-properties.xml @@ -55,9 +55,11 @@ Version of [NetBeans Repository Plugin](https://bits.netbeans.org/mavenutilities/nbm-maven-plugin/nb-repository-plugin/index.html) to use when handling `ant maven-install` invocation. --> - + - + + + From 278e2b855e2a31b423edac02c8c130b6d1e6e6f7 Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Wed, 11 Nov 2026 06:37:24 +0100 Subject: [PATCH 06/17] More explicit warning --- nbbuild/build.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index e75675f9163f..3cf49dbd9ad0 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -415,7 +415,7 @@ metabuild.hash=${metabuild.hash} - + - + @@ -920,7 +920,7 @@ - + @@ -932,7 +932,7 @@ - + From 64dbfc7b537a101b2c42d67bcd58eee24b33a2f8 Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Thu, 12 Nov 2026 09:01:45 +0100 Subject: [PATCH 10/17] Avoid defining base.nbm.target.dir --- nbbuild/build.xml | 8 ++++++-- nbbuild/default-properties.xml | 1 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index 7fea079d9b00..fed20ba809aa 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -319,7 +319,8 @@ metabuild.hash=${metabuild.hash} - + + @@ -330,7 +331,8 @@ metabuild.hash=${metabuild.hash} - + + @@ -452,6 +454,8 @@ metabuild.hash=${metabuild.hash} zip zipFile:'mavenrepo.zip',dir:'mavenrepository',archive:'true' --> + + diff --git a/nbbuild/default-properties.xml b/nbbuild/default-properties.xml index 2393fb975947..a072b9eab325 100644 --- a/nbbuild/default-properties.xml +++ b/nbbuild/default-properties.xml @@ -46,7 +46,6 @@ - From 5e51e25140b7940e1ca95b3d8ac0f35075096805 Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Thu, 12 Nov 2026 10:24:52 +0100 Subject: [PATCH 11/17] Invoke Maven embedder mvn command --- nbbuild/build.xml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index fed20ba809aa..d1ac604d12d3 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -456,7 +456,10 @@ metabuild.hash=${metabuild.hash} - + + + + From 86767523847d9aa547aa4c10a25d3f089be2ee8c Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Thu, 12 Nov 2026 10:41:13 +0100 Subject: [PATCH 12/17] Verify ant maven-install works on all systems --- .github/workflows/main.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 947a973d5614..ca637d477c3c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -475,6 +475,17 @@ jobs: run: | ant $OPTS -Djavadoc.fail.broken.links=true build-javadoc + - name: Maven Install + run: | + # install all NBMs + ant maven-install -Dnbm.install.version=99-SNAPSHOT + # remove one + rm -r $HOME/.m2/repository/org/netbeans/api/org-openide-awt/99-SNAPSHOT/ + # install a single NBM + ant -f platform/openide-awt maven-install -Dnbm.install.version=99-SNAPSHOT + # verify pom is installed + cat $HOME/.m2/repository/org/netbeans/api/org-openide-awt/99-SNAPSHOT/org-openide-awt-99-SNAPSHOT.pom + - name: Create Test Summary uses: test-summary/action@37b508cfee6d4d080eedd00b5bb240a6a784a6a5 # v2.6 if: failure() From 2e4b6b589f25e46914852faef3dceb2a1f128b72 Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Thu, 12 Nov 2026 11:15:54 +0100 Subject: [PATCH 13/17] Typo in platform/openide.awt --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ca637d477c3c..cfe0f91a7749 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -482,7 +482,7 @@ jobs: # remove one rm -r $HOME/.m2/repository/org/netbeans/api/org-openide-awt/99-SNAPSHOT/ # install a single NBM - ant -f platform/openide-awt maven-install -Dnbm.install.version=99-SNAPSHOT + ant -f platform/openide.awt maven-install -Dnbm.install.version=99-SNAPSHOT # verify pom is installed cat $HOME/.m2/repository/org/netbeans/api/org-openide-awt/99-SNAPSHOT/org-openide-awt-99-SNAPSHOT.pom From 620208e61669a55a9e4bf008e57020c20db6cca7 Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Thu, 12 Nov 2026 11:34:44 +0100 Subject: [PATCH 14/17] Only install Javadoc and source ZIPs when available --- nbbuild/build.xml | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/nbbuild/build.xml b/nbbuild/build.xml index d1ac604d12d3..9b8536f1709a 100644 --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -407,16 +407,18 @@ metabuild.hash=${metabuild.hash} - - + - + + + + - + - - + From 82f62876cda5a2240c8d9fe347239a620f309fbb Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Fri, 13 Nov 2026 08:26:36 +0100 Subject: [PATCH 17/17] Verify ant maven-install just after building the NBMs --- .github/workflows/main.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index cfe0f91a7749..53a236a5abdd 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -456,6 +456,17 @@ jobs: - name: Build nbms run: ant $OPTS build-nbms + - name: Maven Install + run: | + # install all NBMs + ant maven-install -Dnbm.install.version=99-SNAPSHOT + # remove one + rm -r $HOME/.m2/repository/org/netbeans/api/org-openide-awt/99-SNAPSHOT/ + # install a single NBM + ant -f platform/openide.awt maven-install -Dnbm.install.version=99-SNAPSHOT + # verify pom is installed + cat $HOME/.m2/repository/org/netbeans/api/org-openide-awt/99-SNAPSHOT/org-openide-awt-99-SNAPSHOT.pom + # runs only in PRs if requested; ~18 min - name: Build all Tests if: env.test_tests == 'true' && github.event_name == 'pull_request' && success() @@ -475,17 +486,6 @@ jobs: run: | ant $OPTS -Djavadoc.fail.broken.links=true build-javadoc - - name: Maven Install - run: | - # install all NBMs - ant maven-install -Dnbm.install.version=99-SNAPSHOT - # remove one - rm -r $HOME/.m2/repository/org/netbeans/api/org-openide-awt/99-SNAPSHOT/ - # install a single NBM - ant -f platform/openide.awt maven-install -Dnbm.install.version=99-SNAPSHOT - # verify pom is installed - cat $HOME/.m2/repository/org/netbeans/api/org-openide-awt/99-SNAPSHOT/org-openide-awt-99-SNAPSHOT.pom - - name: Create Test Summary uses: test-summary/action@37b508cfee6d4d080eedd00b5bb240a6a784a6a5 # v2.6 if: failure()