From a94f5e95dff5f074a119bac98c14953f68ce88a9 Mon Sep 17 00:00:00 2001 From: ump45nose Date: Fri, 6 Nov 2026 03:38:42 +0800 Subject: [PATCH] GH-55410: [Docs][C++] Fix is_printable empty-string FunctionDoc utf8_is_printable and ascii_is_printable allow empty strings (matching Python str.isprintable()), but StringClassifyDoc was called with non_empty=true, which documented the opposite. Pass false so the docs match the kernels. --- cpp/src/arrow/compute/kernels/scalar_string_ascii.cc | 2 +- cpp/src/arrow/compute/kernels/scalar_string_utf8.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc b/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc index dd3c507ef53e..55a7efacc891 100644 --- a/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc +++ b/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc @@ -668,7 +668,7 @@ const auto ascii_is_decimal_doc = const auto ascii_is_lower_doc = StringClassifyDoc("ASCII lowercase", "lowercase ASCII characters", true); const auto ascii_is_printable_doc = - StringClassifyDoc("ASCII printable", "printable ASCII characters", true); + StringClassifyDoc("ASCII printable", "printable ASCII characters", false); const auto ascii_is_space_doc = StringClassifyDoc("ASCII whitespace", "whitespace ASCII characters", true); const auto ascii_is_upper_doc = diff --git a/cpp/src/arrow/compute/kernels/scalar_string_utf8.cc b/cpp/src/arrow/compute/kernels/scalar_string_utf8.cc index 6d4525c28696..abb9a63db8ab 100644 --- a/cpp/src/arrow/compute/kernels/scalar_string_utf8.cc +++ b/cpp/src/arrow/compute/kernels/scalar_string_utf8.cc @@ -310,7 +310,7 @@ const auto utf8_is_lower_doc = const auto utf8_is_numeric_doc = StringClassifyDoc("numeric", "numeric Unicode characters", true); const auto utf8_is_printable_doc = - StringClassifyDoc("printable", "printable Unicode characters", true); + StringClassifyDoc("printable", "printable Unicode characters", false); const auto utf8_is_space_doc = StringClassifyDoc("whitespace", "whitespace Unicode characters", true); const auto utf8_is_upper_doc =