From ffa09a4aa4daab8032dab6fc91236cc736992c6b Mon Sep 17 00:00:00 2001 From: Tobias Fischer Date: Sat, 14 Nov 2026 20:24:09 +1000 Subject: [PATCH] mrpt_gui: no wxpython host dependency, rebuild mrpt_gui links the C++ wxWidgets libraries (libwx_*), but its wxwidgets/wx-common rosdep keys map to wxpython, which its recipes had as a host dependency (never a run one). conda-forge's wxpython builds for wxwidgets 3.3.4 need sip >=6.17, while pyqt6 needs sip <6.16 and the pins hold sip at 6.15, so with the pinning update (#165) check-deps, which solves host and run requirements together, reports conflicts with python_qt_binding / qt_gui_cpp in lyrical and rolling. mrpt_gui is rebuilt in all distributions (humble 24, jazzy 30, lyrical 34, rolling 35). Co-Authored-By: Claude Opus 5.5 --- distros/humble/pkg_additional_info.yaml | 2 ++ distros/jazzy/pkg_additional_info.yaml | 2 ++ distros/lyrical/pkg_additional_info.yaml | 2 ++ distros/rolling/pkg_additional_info.yaml | 2 ++ shared/patch/dependencies.yaml | 5 +++-- 5 files changed, 11 insertions(+), 2 deletions(-) diff --git a/distros/humble/pkg_additional_info.yaml b/distros/humble/pkg_additional_info.yaml index bcc19fc1..9005c719 100644 --- a/distros/humble/pkg_additional_info.yaml +++ b/distros/humble/pkg_additional_info.yaml @@ -111,6 +111,8 @@ ament_cmake_gtest: # uses conda-forge's gtest instead of gtest_vendor's sources build_number: 23 aruco_ros: # its recipe test stops the node for sure (package tests hung on macOS) build_number: 23 +mrpt_gui: + build_number: 24 rtabmap_slam: # its recipe test stops the node for sure (package tests hung on macOS) build_number: 23 spatio_temporal_voxel_layer: diff --git a/distros/jazzy/pkg_additional_info.yaml b/distros/jazzy/pkg_additional_info.yaml index 129677d4..20b101a5 100644 --- a/distros/jazzy/pkg_additional_info.yaml +++ b/distros/jazzy/pkg_additional_info.yaml @@ -145,6 +145,8 @@ moveit_ros_visualization: build_number: 28 moveit_task_constructor_visualization: build_number: 28 +mrpt_gui: + build_number: 30 nav2_rviz_plugins: build_number: 28 octomap_rviz_plugins: diff --git a/distros/lyrical/pkg_additional_info.yaml b/distros/lyrical/pkg_additional_info.yaml index 5266ede7..bd035c92 100644 --- a/distros/lyrical/pkg_additional_info.yaml +++ b/distros/lyrical/pkg_additional_info.yaml @@ -131,6 +131,8 @@ moveit_ros_visualization: build_number: 31 moveit_task_constructor_visualization: build_number: 31 +mrpt_gui: + build_number: 34 nav2_rviz_plugins: build_number: 31 rtabmap_rviz_plugins: diff --git a/distros/rolling/pkg_additional_info.yaml b/distros/rolling/pkg_additional_info.yaml index 8e3d8466..3fd43aa5 100644 --- a/distros/rolling/pkg_additional_info.yaml +++ b/distros/rolling/pkg_additional_info.yaml @@ -79,6 +79,8 @@ moveit_ros_visualization: build_number: 33 moveit_task_constructor_visualization: build_number: 33 +mrpt_gui: + build_number: 35 rviz_2d_overlay_plugins: build_number: 33 rviz_common: diff --git a/shared/patch/dependencies.yaml b/shared/patch/dependencies.yaml index b2b946bd..c1984a70 100644 --- a/shared/patch/dependencies.yaml +++ b/shared/patch/dependencies.yaml @@ -88,10 +88,11 @@ mrpt_common: # but package.xml (build_type cmake) does not declare it add_host: ["ros2-ament-cmake"] mrpt_gui: - # links libwx_*; the wxwidgets/wx-common keys map to wxpython, so wxwidgets is only a - # transitive host dep and its (weak) run_exports never reach the run requirements + # links libwx_* (C++), but the wxwidgets/wx-common keys map to wxpython: wxwidgets + # directly, and no wxpython (whose builds for wxwidgets 3.3.4 need a newer sip than pyqt's) # Windows: nanogui links conda-forge's glad instead of its bundled copy (ros2-mrpt-gui.win.patch) add_host: ["wxwidgets", "${{ 'glad' if win }}"] + remove_host: ["wxpython"] mrpt_imgui: # Windows: links conda-forge's GLEW like mrpt_opengl, also for its users (ros2-mrpt-imgui.win.patch) add_host: ["${{ 'glew' if win }}"]