diff --git a/Changelog b/Changelog index 9caba8da7..9fee5802c 100644 --- a/Changelog +++ b/Changelog @@ -167,16 +167,16 @@ This patch contains some other enhancements which improve performance of DRC, although in certain cases only. * Enhancement: %GITHUB%/issues/2300 More options to set layout format, specifically on LEF/DEF -* Bugfix: %GITHUB%/2301 UI freezes permanently with open Macro Development window and event listening plugin +* Bugfix: %GITHUB%/issues/2301 UI freezes permanently with open Macro Development window and event listening plugin * Bugfix: %GITHUB%/issues/2305 Library reloading problems -* Enhancement: %GITHUB%/2306 Feature Request: API-access to a setter for the selected entry in the Netlist Database Browser -* Bugfix: %GITHUB%/2311 Tip window is shown although running in non-GUI modebug -* Bugfix: %GITHUB%/2315 Edit/Layout/Scale causes confusing -* Enhancement: %GITHUB%/2316 Edit/Selection/Make Array: support both pitch and spacing -* Bugfix: %GITHUB%/2320 Failure to read OASIS files with large property strings -* Enhancement: %GITHUB%/2322 Options(text): split text scaling and rotation into two separate options -* Enhancement: %GITHUB%/2326 Fit shouldn't take bbox of "empty" struct into account -* Bugfix: %GITHUB%/2331 Screen size error (Assertion tlPixelBuffer.cc:260 n < m_height was not true) +* Enhancement: %GITHUB%/issues/2306 Feature Request: API-access to a setter for the selected entry in the Netlist Database Browser +* Bugfix: %GITHUB%/issues/2311 Tip window is shown although running in non-GUI modebug +* Bugfix: %GITHUB%/issues/2315 Edit/Layout/Scale causes confusing +* Enhancement: %GITHUB%/issues/2316 Edit/Selection/Make Array: support both pitch and spacing +* Bugfix: %GITHUB%/issues/2320 Failure to read OASIS files with large property strings +* Enhancement: %GITHUB%/issues/2322 Options(text): split text scaling and rotation into two separate options +* Enhancement: %GITHUB%/issues/2326 Fit shouldn't take bbox of "empty" struct into account +* Bugfix: %GITHUB%/issues/2331 Screen size error (Assertion tlPixelBuffer.cc:260 n < m_height was not true) * Enhancement: "strmrun" now can run DRC and LVS scripts * Enhancement: "Library#library_by_name" now can be used with "*" for technology * Bugfix: PCell "coerce_parameters" and "callback" was called with the client layout @@ -620,7 +620,7 @@ * Bugfix: Properly transferring ownership for variant to Python/Ruby translation. This is required for some Python and Ruby bindings, when objects are transferred through generic arrays. -* Enhancement: Added Region#being_shapes_rec and Region#begin_merged_shapes_rec. +* Enhancement: Added Region#begin_shapes_rec and Region#begin_merged_shapes_rec. Mainly for being able to retrieve shapes with properties from Region#nets * Enhancement: Convenience methods Shape#properties, Layout#properties, Cell#properties, Instance#properties. These method will obtain all properties as a hash. diff --git a/src/db/db/dbAsIfFlatTexts.cc b/src/db/db/dbAsIfFlatTexts.cc index aaa357c2c..e4bb2fc7b 100644 --- a/src/db/db/dbAsIfFlatTexts.cc +++ b/src/db/db/dbAsIfFlatTexts.cc @@ -405,8 +405,8 @@ AsIfFlatTexts::selected_interacting_generic (const Region &other, bool inverse) { // shortcuts if (other.empty () || empty ()) { - return new EmptyTexts (); - } + return inverse ? clone () : new EmptyTexts (); + } db::box_scanner2 scanner (report_progress (), progress_desc ()); diff --git a/src/db/unit_tests/dbTextsTests.cc b/src/db/unit_tests/dbTextsTests.cc index 8ec198b83..7f22c6e1d 100644 --- a/src/db/unit_tests/dbTextsTests.cc +++ b/src/db/unit_tests/dbTextsTests.cc @@ -198,13 +198,25 @@ TEST(7) EXPECT_EQ (tcopy.to_string (), "('abc',r0 100,-200)"); } - { + { + db::Texts tcopy = texts; + tcopy.select_interacting (db::Region ()); + EXPECT_EQ (tcopy.to_string (), ""); + } + + { db::Texts tcopy = texts; tcopy.select_not_interacting (region); EXPECT_EQ (tcopy.to_string (), "('uvw',r0 110,210)"); } - db::Region region_out; + { + db::Texts tcopy = texts; + tcopy.select_not_interacting (db::Region ()); + EXPECT_EQ (tcopy.to_string (), "('abc',r0 100,-200);('uvw',r0 110,210)"); + } + + db::Region region_out; texts.pull_interacting (region_out, region); EXPECT_EQ (region_out.to_string (), "(50,-300;50,-100;150,-100;150,-300)"); }