Skip to content

Commit e3fe0fd

Browse files
author
Jasper Geurtz
committed
Revert Player.getTextColor White color ID to 84 and document BWAPI 4.4.0 bug
# Conflicts: # src/main/java/bwapi/Player.java
1 parent 735840f commit e3fe0fd

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎src/main/java/bwapi/Player.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,6 +555,8 @@ public Color getColor() {
555555
* @return character code to use for text in Broodwar.
556556
*/
557557
public Text getTextColor() {
558+
// Note: C++ BWAPI 4.4.0 uses Colors::White (255) and Colors::Green (117) due to a bug,
559+
// whereas Player 7 white is 84 (DirtyWhite) and Player 9 / Ice green is 185 (DarkGreen).
558560
switch (getColor().id) {
559561
case 111: // red
560562
return Text.BrightRed;
@@ -568,7 +570,7 @@ public Text getTextColor() {
568570
return Text.Orange;
569571
case 19: // brown
570572
return Text.Brown;
571-
case 255: // white
573+
case 84: // white
572574
return Text.PlayerWhite;
573575
case 135: // yellow
574576
return Text.PlayerYellow;

0 commit comments

Comments
 (0)