Fix UnitCommand.assignTarget bounds clamping and document equals/hashCode difference

Author: Jasper Geurtz

src/main/java/bwapi/Point.java

@@ -5,7 +5,7 @@ public abstract class Point<T extends Point<T>> implements Comparable<Point<T>>
 
     public final int x;
     public final int y;
-    private final int scalar;
+    final int scalar;
 
     protected Point(final int x, final int y, final int type) {
         this.x = x;

src/main/java/bwapi/UnitCommand.java

@@ -20,8 +20,14 @@ private UnitCommand(final Unit unit, final UnitCommandType type) {
     }
 
     private <T extends Point<T>> void assignTarget(Point<T> target) {
-        this.x = target.x;
-        this.y = target.y;
+        final int maxW = (unit != null && unit.game != null && unit.game.mapPixelWidth() > 0
+                ? unit.game.mapPixelWidth()
+                : 256 * 32) / target.scalar - 1;
+        final int maxH = (unit != null && unit.game != null && unit.game.mapPixelHeight() > 0
+                ? unit.game.mapPixelHeight()
+                : 256 * 32) / target.scalar - 1;
+        this.x = Math.min(Math.max(0, target.x), maxW);
+        this.y = Math.min(Math.max(0, target.y), maxH);
     }
 
     public static UnitCommand attack(final Unit unit, final Position target) {
@@ -410,6 +416,7 @@ public boolean isQueued() {
                 && extra != 0;
     }
 
+    // Note: C++ BWAPI excludes `unit` when comparing UnitCommands, but JBWAPI includes `unit` in equals and hashCode.
     @Override
     public boolean equals(Object o) {
         if (this == o) return true;