From 9fe42aa6c0b9a2a27194e973def0b4fb8c67c0a2 Mon Sep 17 00:00:00 2001 From: Nihar Dalal <140463192+nihardalal@users.noreply.github.com> Date: Thu, 29 Oct 2026 10:38:13 -0700 Subject: [PATCH 1/2] Update diameter and fix comment typo Updated the diameter value for accuracy and corrected a typo in the comment. --- galsim/roman/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/galsim/roman/__init__.py b/galsim/roman/__init__.py index 8d5aee8fd4..7c85fa59a0 100644 --- a/galsim/roman/__init__.py +++ b/galsim/roman/__init__.py @@ -25,7 +25,7 @@ gain = 1.0 pixel_scale = 0.11 # arcsec / pixel -diameter = 2.36 # meters +diameter = 2.36312 # meters (updated from STPSF/PSFSim) obscuration = 0.32 collecting_area = 3.757e4 # cm^2, from Cycle 7 exptime = 139.8 # s @@ -96,7 +96,7 @@ jitter_rms = 0.014 charge_diffusion = 0.1 -# Maxinum allowed angle from the telecope solar panels to the sun in degrees. +# Maximum allowed angle from the telecope solar panels to the sun in degrees. max_sun_angle = 36. from .roman_bandpass import getBandpass, getBandpasses From 12c9076fe3707233a3fea43b25c8240294ff9d32 Mon Sep 17 00:00:00 2001 From: Nihar Dalal <140463192+nihardalal@users.noreply.github.com> Date: Thu, 29 Oct 2026 11:46:27 -0700 Subject: [PATCH 2/2] Update reference diameter in test_roman.py --- tests/test_roman.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_roman.py b/tests/test_roman.py index 60b5a90c74..46a867e426 100644 --- a/tests/test_roman.py +++ b/tests/test_roman.py @@ -831,7 +831,7 @@ def test_roman_basic_numbers(): # Would be better to have a non-trivial test, but this will do for now. ref_gain = 1.0 ref_pixel_scale = 0.11 # arcsec / pixel - ref_diameter = 2.36 # meters + ref_diameter = 2.36312 # meters ref_obscuration = 0.32 ref_exptime = 139.8 # s ref_dark_current = 0.015 # e-/pix/s