From 638a6424cf32215f34cf657fbbdedbb7fa57953d Mon Sep 17 00:00:00 2001 From: Simon Schick Date: Tue, 10 Nov 2026 19:50:25 -0800 Subject: [PATCH] chore: publish locally to GitHub Packages, drop release-please - version 10.0.0, .npmrc maps @conventioncatcorp to GitHub Packages - prepublishOnly runs typecheck, lint, tests and build - docs deploy on push to master instead of on release Co-Authored-By: Claude Opus 5.5 --- .github/workflows/docs.yml | 4 ++-- .github/workflows/release-please.yml | 33 ---------------------------- .npmrc | 1 + .release-please-manifest.json | 1 - AGENTS.md | 2 +- CHANGELOG.md | 5 +++++ README.md | 11 +++++++++- package.json | 4 ++-- release-please-config.json | 30 ------------------------- v10-migration.md | 16 ++++++-------- 10 files changed, 28 insertions(+), 79 deletions(-) delete mode 100644 .github/workflows/release-please.yml create mode 100644 .npmrc delete mode 100644 .release-please-manifest.json delete mode 100644 release-please-config.json diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index b37f557ea..9b89eaf62 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -1,8 +1,8 @@ name: Docs on: - release: - types: [published] + push: + branches: [master] workflow_dispatch: permissions: diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml deleted file mode 100644 index 20be4e618..000000000 --- a/.github/workflows/release-please.yml +++ /dev/null @@ -1,33 +0,0 @@ -name: Release - -on: - push: - branches: [master] - -permissions: - contents: write - pull-requests: write - packages: write - -jobs: - release: - runs-on: ubuntu-latest - steps: - - uses: googleapis/release-please-action@v5 - id: release - with: - config-file: release-please-config.json - manifest-file: .release-please-manifest.json - - if: ${{ steps.release.outputs.release_created }} - uses: actions/checkout@v7 - - if: ${{ steps.release.outputs.release_created }} - uses: actions/setup-node@v7 - with: - node-version-file: .nvmrc - cache: npm - registry-url: https://npm.pkg.github.com - scope: '@conventioncatcorp' - - if: ${{ steps.release.outputs.release_created }} - run: npm ci && npm publish - env: - NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.npmrc b/.npmrc new file mode 100644 index 000000000..946660bab --- /dev/null +++ b/.npmrc @@ -0,0 +1 @@ +@conventioncatcorp:registry=https://npm.pkg.github.com diff --git a/.release-please-manifest.json b/.release-please-manifest.json deleted file mode 100644 index 3d6970222..000000000 --- a/.release-please-manifest.json +++ /dev/null @@ -1 +0,0 @@ -{ ".": "9.2.3" } diff --git a/AGENTS.md b/AGENTS.md index 4d4895d2d..cf7235e71 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -56,7 +56,7 @@ PolymorphicExtras` (spell `XOwnProps` out, or Storybook docgen los - Use `import type` for types (`verbatimModuleSyntax`). Named React imports, no `import React` unless needed. - Class names go through `mapToCssModules(classNames(...), cssModule)`. - Bootstrap 5 only: don't add Bootstrap 4 classes/props back. -- Commits: Conventional Commits (release-please builds the changelog and releases from `master`). +- Commits: Conventional Commits. Releases are published locally (`npm version` + `npm publish`, see README); no CI release. ## Gotchas diff --git a/CHANGELOG.md b/CHANGELOG.md index 7bb91fe9d..3baed29d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +# 10.0.0 (2026-11-10) + +First release of `@conventioncatcorp/reactstrap`, the ConventionCatCorp fork. TypeScript, React 19 and Bootstrap 5 +only, with typed polymorphic `tag`. Breaking changes and the upgrade guide are in [v10-migration.md](v10-migration.md). + # [9.0.0-8](https://github.com/reactstrap/reactstrap/compare/v9.0.0-7...v9.0.0-8) (2021-10-15) diff --git a/README.md b/README.md index b695ccb67..4eeee3ca4 100644 --- a/README.md +++ b/README.md @@ -115,7 +115,16 @@ npm run build # dist/ (Vite lib build + tsc declarations) ## Releasing -Release branches/versioning/notes will be automatically created and maintained by the [release-please](https://github.com/googleapis/release-please) github action. When you're ready to publish the release, just merge the release branch. The release will be created, the package is published to GitHub Packages, and the docs are deployed to GitHub Pages. +Published from a local machine to GitHub Packages (`.npmrc` maps the `@conventioncatcorp` scope; your `~/.npmrc` needs +a token with `write:packages` for `//npm.pkg.github.com/`): + +```sh +npm version # bumps package.json, commits and tags +npm publish # prepublishOnly runs typecheck, lint, tests and build +git push --follow-tags +``` + +Storybook docs deploy to GitHub Pages on every push to `master`. ## In the wild diff --git a/package.json b/package.json index 8a032a44b..8a90c2890 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@conventioncatcorp/reactstrap", - "version": "9.2.3", + "version": "10.0.0", "description": "React 19 components for Bootstrap 5 (ConventionCatCorp fork of reactstrap)", "type": "module", "main": "./dist/index.js", @@ -28,7 +28,7 @@ "cover": "vitest run --coverage", "start": "storybook dev -p 8080", "build:docs": "storybook build -o build", - "prepublishOnly": "npm run build" + "prepublishOnly": "npm run typecheck && npm run lint && npm run test:ci && npm run build" }, "prettier": { "singleQuote": true, diff --git a/release-please-config.json b/release-please-config.json deleted file mode 100644 index 8fe92d860..000000000 --- a/release-please-config.json +++ /dev/null @@ -1,30 +0,0 @@ -{ - "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", - "include-component-in-tag": false, - "packages": { - ".": { - "release-type": "node", - "package-name": "@conventioncatcorp/reactstrap", - "changelog-sections": [ - { - "type": "feat", - "section": "Features" - }, - { - "type": "fix", - "section": "Bug Fixes" - }, - { - "type": "refactor", - "section": "Miscellaneous" - }, - { - "type": "chore", - "section": "Miscellaneous", - "hidden": true - } - ], - "release-as": "10.0.0" - } - } -} diff --git a/v10-migration.md b/v10-migration.md index eb3f10866..731c62ef7 100644 --- a/v10-migration.md +++ b/v10-migration.md @@ -128,9 +128,9 @@ deprecation tests went with them. New regression tests cover the React 19 bugs l - **CI** (`.github/workflows`): - `ci.yml` replaces `test.yml` + `coverage.yml`. It runs on Node from `.nvmrc`: lint → format:check → typecheck → cover → build → build:docs, then uploads to Coveralls. - - `release-please.yml` runs release-please v5 in manifest mode (`release-as: 10.0.0`) and publishes to GitHub Packages - with `GITHUB_TOKEN`. - - `docs.yml` deploys Storybook to GitHub Pages. This replaces `scripts/docs`, which pushed to the upstream + - No CI release: release-please is gone. Releases are published locally to GitHub Packages (`npm version`, then + `npm publish`); `prepublishOnly` runs typecheck, lint, tests and build first. + - `docs.yml` deploys Storybook to GitHub Pages on every push to `master`. This replaces `scripts/docs`, which pushed to the upstream `reactstrap.github.io` repo. - Actions: checkout v7, setup-node v7, upload-pages-artifact v5, deploy-pages v5. - Dependabot covers npm and actions weekly, grouped. @@ -196,12 +196,10 @@ prettier 3.9, storybook 10.6 (+ react-vite, addon-docs, addon-links), react / re TooltipPopoverWrapper, UncontrolledDropdown. - They are the riskiest to rewrite, and `PopperContent` must stay a class for the `defaultProps` patch. - Converting them to hooks is a follow-up; it needs a replacement for that patch, e.g. a defaults context. -3. **GitHub Packages vs `npm.concat.app`.** - - ConCat's `.npmrc` maps `@conventioncatcorp` to GitHub Packages, so this repo publishes there. - - But the umzug fork's repo publishes `@concat/umzug` to `npm.concat.app`. - - Confirm which registry is canonical. -4. **Versioning.** `package.json` stays at 9.2.3. `release-please-config.json` sets `release-as: 10.0.0`; remove that - after the first release. +3. **Registry:** GitHub Packages (`@conventioncatcorp`), same as ConCat's `.npmrc`. The umzug fork's repo still names + `@concat/umzug` on `npm.concat.app`, so that repo looks out of date. +4. **ConCat `min-release-age=3`** stops npm from resolving versions younger than 3 days. Install a fresh release once + with `npm install --min-release-age=0` to update the lockfile; `npm ci` installs from the lockfile and is unaffected. 5. **Kept oddities:** - `CarouselControl` renders `` without keyboard handling; Bootstrap 5 uses a `