From 82a2bd68e7c273abe553822bb58351aa526029fd Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 28 Oct 2026 10:33:16 +0000 Subject: [PATCH 1/3] fix: support pytest 9.2 fixture manager changes pytest 9.2 replaced the private `FixtureManager._arg2fixturedefs` with `_arg2node2fixturedefs` (pytest-dev/pytest#14984). The `pytest_plugin_registered` hook wrote into `_arg2fixturedefs` to swap pytest-benchmark's `benchmark` fixture for ours, so every `--codspeed` run with pytest-benchmark installed crashed with an AttributeError. On pytest 9.1+, register the override through the public `pytest.register_fixture` API at session start instead. Older pytest keeps the previous `_arg2fixturedefs` swap. pytest-benchmark itself still reads the removed `Node._nodeid` on pytest 9.2, so the two tests that run it without `--codspeed` are marked as non-strict xfail on that combination. Co-Authored-By: Guillaume Lagrange <19265358+GuillaumeLagrange@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 --- src/pytest_codspeed/plugin.py | 64 +++++++++++++++++++++++------------ src/pytest_codspeed/utils.py | 2 ++ tests/conftest.py | 5 +++ tests/test_pytest_plugin.py | 3 ++ 4 files changed, 53 insertions(+), 21 deletions(-) diff --git a/src/pytest_codspeed/plugin.py b/src/pytest_codspeed/plugin.py index 2b50a8b..ced3fd3 100644 --- a/src/pytest_codspeed/plugin.py +++ b/src/pytest_codspeed/plugin.py @@ -23,6 +23,7 @@ from pytest_codspeed.instruments import MeasurementMode, get_instrument_from_mode from pytest_codspeed.utils import ( BEFORE_PYTEST_8_1_1, + HAS_PYTEST_REGISTER_FIXTURE, IS_PYTEST_BENCHMARK_INSTALLED, IS_PYTEST_SPEED_INSTALLED, get_environment_metadata, @@ -181,20 +182,40 @@ def pytest_configure(config: pytest.Config): config.pluginmanager.register(plugin, PLUGIN_NAME) -@pytest.hookimpl() -def pytest_plugin_registered(plugin, manager: pytest.PytestPluginManager): - """ - Patch the benchmark fixture to use the codspeed one if codspeed is enabled and an - alternative benchmark fixture is available - """ - if (IS_PYTEST_BENCHMARK_INSTALLED or IS_PYTEST_SPEED_INSTALLED) and isinstance( - plugin, FixtureManager - ): - fixture_manager = plugin - codspeed_plugin: CodSpeedPlugin = cast( - "CodSpeedPlugin", manager.get_plugin(PLUGIN_NAME) - ) - if codspeed_plugin.is_codspeed_enabled: +def _should_override_benchmark_fixture(config: pytest.Config) -> bool: + if not (IS_PYTEST_BENCHMARK_INSTALLED or IS_PYTEST_SPEED_INSTALLED): + return False + codspeed_plugin = cast( + "CodSpeedPlugin | None", config.pluginmanager.get_plugin(PLUGIN_NAME) + ) + return codspeed_plugin is not None and codspeed_plugin.is_codspeed_enabled + + +if HAS_PYTEST_REGISTER_FIXTURE: + + @pytest.hookimpl(trylast=True) + def pytest_sessionstart(session: pytest.Session): + """ + Override the benchmark fixture of pytest-benchmark/pytest-speed with the + codspeed one. Registered later at the same (session) level, so it wins. + """ + if _should_override_benchmark_fixture(session.config): + pytest.register_fixture( + name="benchmark", func=_benchmark_compat, node=session + ) + +else: + + @pytest.hookimpl() + def pytest_plugin_registered(plugin, manager: pytest.PytestPluginManager): + """ + Patch the benchmark fixture to use the codspeed one if codspeed is enabled and + an alternative benchmark fixture is available + """ + if isinstance(plugin, FixtureManager) and _should_override_benchmark_fixture( + plugin.config + ): + fixture_manager = plugin codspeed_benchmark_fixtures = plugin.getfixturedefs( "codspeed_benchmark", fixture_manager.session.nodeid @@ -433,11 +454,12 @@ def codspeed_benchmark(request: pytest.FixtureRequest) -> Callable: return BenchmarkFixture(request) -if not IS_PYTEST_BENCHMARK_INSTALLED: +def _benchmark_compat(codspeed_benchmark, request: pytest.FixtureRequest): + """ + Compatibility with pytest-benchmark + """ + return codspeed_benchmark - @pytest.fixture(scope="function") - def benchmark(codspeed_benchmark, request: pytest.FixtureRequest): - """ - Compatibility with pytest-benchmark - """ - return codspeed_benchmark + +if not IS_PYTEST_BENCHMARK_INSTALLED: + benchmark = pytest.fixture(scope="function", name="benchmark")(_benchmark_compat) diff --git a/src/pytest_codspeed/utils.py b/src/pytest_codspeed/utils.py index 6c24143..95b9256 100644 --- a/src/pytest_codspeed/utils.py +++ b/src/pytest_codspeed/utils.py @@ -19,6 +19,8 @@ IS_PYTEST_BENCHMARK_INSTALLED = importlib.util.find_spec("pytest_benchmark") is not None IS_PYTEST_SPEED_INSTALLED = importlib.util.find_spec("pytest_speed") is not None BEFORE_PYTEST_8_1_1 = pytest.version_tuple < (8, 1, 1) +# Public API since pytest 9.1, required since 9.2 removed `_arg2fixturedefs` +HAS_PYTEST_REGISTER_FIXTURE = hasattr(pytest, "register_fixture") SUPPORTS_PERF_TRAMPOLINE = sysconfig.get_config_var("PY_HAVE_PERF_TRAMPOLINE") == 1 diff --git a/tests/conftest.py b/tests/conftest.py index e8a5625..c03d074 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -23,6 +23,11 @@ skip_with_pytest_benchmark = pytest.mark.skipif( IS_PYTEST_BENCHMARK_INSTALLED, reason="pytest_benchmark installed" ) +xfail_pytest_benchmark_on_pytest_9_2 = pytest.mark.xfail( + IS_PYTEST_BENCHMARK_INSTALLED and pytest.version_tuple >= (9, 2), + reason="pytest-benchmark is incompatible with pytest 9.2 (Node._nodeid removal)", + strict=False, +) if IS_PYTEST_BENCHMARK_INSTALLED: pytest_plugins.append("pytest_benchmark") print( diff --git a/tests/test_pytest_plugin.py b/tests/test_pytest_plugin.py index 452e9da..a266649 100644 --- a/tests/test_pytest_plugin.py +++ b/tests/test_pytest_plugin.py @@ -6,6 +6,7 @@ skip_with_perf_trampoline, skip_without_pytest_benchmark, skip_without_valgrind, + xfail_pytest_benchmark_on_pytest_9_2, ) @@ -119,6 +120,7 @@ def test_child(self): ) +@xfail_pytest_benchmark_on_pytest_9_2 def test_plugin_disabled(pytester: pytest.Pytester) -> None: pytester.copy_example("tests/examples/test_addition_fixture.py") result = pytester.runpytest() @@ -191,6 +193,7 @@ def test_another_useless_thing(): ) +@xfail_pytest_benchmark_on_pytest_9_2 @skip_without_pytest_benchmark def test_pytest_benchmark_compatibility(pytester: pytest.Pytester) -> None: pytester.makepyfile( From 3af46995392d2888148d8be506bc60d2bb22f2d9 Mon Sep 17 00:00:00 2001 From: Guillaume Lagrange Date: Wed, 28 Oct 2026 11:53:49 +0100 Subject: [PATCH 2/3] ci: test older pytest versions and run valgrind tests with pytest-benchmark The matrix only installed the latest pytest, so the fixture override paths for pytest without register_fixture (9.0) and before 8.1.1 were never exercised. Add pytest 9.0 and 8.0 jobs on Python 3.15 only, to avoid the full combinatorial matrix. The valgrind install condition matched a "pytest-benchmark" config that no longer exists since the split into -4 and -5, so the valgrind tests running --codspeed with pytest-benchmark installed were always skipped. Co-Authored-By: Claude --- .github/workflows/ci.yml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9f82262..9b0cee1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -47,6 +47,22 @@ jobs: - version: "3.15t" pytest-version: - ">=8.1.1" + # Older pytest versions only on the latest Python + include: + # Before pytest.register_fixture (private _arg2fixturedefs override) + - config: headless + python: { version: "3.15" } + pytest-version: "~=9.0.0" + - config: pytest-benchmark-5 + python: { version: "3.15" } + pytest-version: "~=9.0.0" + # Before 8.1.1 (getfixturedefs takes a nodeid) + - config: headless + python: { version: "3.15" } + pytest-version: "~=8.0.0" + - config: pytest-benchmark-4 + python: { version: "3.15" } + pytest-version: "~=8.0.0" steps: - uses: actions/checkout@v5 @@ -57,7 +73,7 @@ jobs: uses: actions/setup-python@v6 with: python-version: "${{ matrix.python.version }}" - - if: matrix.config == 'valgrind' || matrix.config == 'pytest-benchmark' + - if: matrix.config == 'valgrind' || startsWith(matrix.config, 'pytest-benchmark') name: Install valgrind run: | sudo apt-get update From cd4265ea1848609861505300b9349b8a15edcbb6 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 28 Oct 2026 16:02:31 +0000 Subject: [PATCH 3/3] refactor: minimize pytest 9.2 compatibility diff Keep the original `benchmark` fixture and `pytest_plugin_registered` hook untouched, and only add the pytest 9.1+ path: the hook returns early when `pytest.register_fixture` is available, and a new `pytest_sessionstart` hook registers the codspeed `benchmark` override at session level instead. Co-Authored-By: Arthur Pastel <15641577+art049@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 --- src/pytest_codspeed/plugin.py | 85 ++++++++++++++++++----------------- 1 file changed, 43 insertions(+), 42 deletions(-) diff --git a/src/pytest_codspeed/plugin.py b/src/pytest_codspeed/plugin.py index ced3fd3..6b21a89 100644 --- a/src/pytest_codspeed/plugin.py +++ b/src/pytest_codspeed/plugin.py @@ -182,40 +182,22 @@ def pytest_configure(config: pytest.Config): config.pluginmanager.register(plugin, PLUGIN_NAME) -def _should_override_benchmark_fixture(config: pytest.Config) -> bool: - if not (IS_PYTEST_BENCHMARK_INSTALLED or IS_PYTEST_SPEED_INSTALLED): - return False - codspeed_plugin = cast( - "CodSpeedPlugin | None", config.pluginmanager.get_plugin(PLUGIN_NAME) - ) - return codspeed_plugin is not None and codspeed_plugin.is_codspeed_enabled - - -if HAS_PYTEST_REGISTER_FIXTURE: - - @pytest.hookimpl(trylast=True) - def pytest_sessionstart(session: pytest.Session): - """ - Override the benchmark fixture of pytest-benchmark/pytest-speed with the - codspeed one. Registered later at the same (session) level, so it wins. - """ - if _should_override_benchmark_fixture(session.config): - pytest.register_fixture( - name="benchmark", func=_benchmark_compat, node=session - ) - -else: - - @pytest.hookimpl() - def pytest_plugin_registered(plugin, manager: pytest.PytestPluginManager): - """ - Patch the benchmark fixture to use the codspeed one if codspeed is enabled and - an alternative benchmark fixture is available - """ - if isinstance(plugin, FixtureManager) and _should_override_benchmark_fixture( - plugin.config - ): - fixture_manager = plugin +@pytest.hookimpl() +def pytest_plugin_registered(plugin, manager: pytest.PytestPluginManager): + """ + Patch the benchmark fixture to use the codspeed one if codspeed is enabled and an + alternative benchmark fixture is available + """ + if HAS_PYTEST_REGISTER_FIXTURE: + return # handled in pytest_sessionstart + if (IS_PYTEST_BENCHMARK_INSTALLED or IS_PYTEST_SPEED_INSTALLED) and isinstance( + plugin, FixtureManager + ): + fixture_manager = plugin + codspeed_plugin: CodSpeedPlugin = cast( + "CodSpeedPlugin", manager.get_plugin(PLUGIN_NAME) + ) + if codspeed_plugin.is_codspeed_enabled: codspeed_benchmark_fixtures = plugin.getfixturedefs( "codspeed_benchmark", fixture_manager.session.nodeid @@ -231,6 +213,26 @@ def pytest_plugin_registered(plugin, manager: pytest.PytestPluginManager): fixture_manager._arg2fixturedefs["benchmark"] = codspeed_benchmark_fixtures +def _benchmark_compat(codspeed_benchmark, request: pytest.FixtureRequest): + return codspeed_benchmark + + +@pytest.hookimpl(trylast=True) +def pytest_sessionstart(session: pytest.Session): + """ + Override the benchmark fixture of pytest-benchmark/pytest-speed with the codspeed + one, using the public API available since pytest 9.1 + """ + if HAS_PYTEST_REGISTER_FIXTURE and ( + IS_PYTEST_BENCHMARK_INSTALLED or IS_PYTEST_SPEED_INSTALLED + ): + codspeed_plugin = session.config.pluginmanager.get_plugin(PLUGIN_NAME) + if codspeed_plugin is not None and codspeed_plugin.is_codspeed_enabled: + pytest.register_fixture( + name="benchmark", func=_benchmark_compat, node=session + ) + + @pytest.hookimpl(trylast=True) def pytest_report_header(config: pytest.Config): plugin = get_plugin(config) @@ -454,12 +456,11 @@ def codspeed_benchmark(request: pytest.FixtureRequest) -> Callable: return BenchmarkFixture(request) -def _benchmark_compat(codspeed_benchmark, request: pytest.FixtureRequest): - """ - Compatibility with pytest-benchmark - """ - return codspeed_benchmark - - if not IS_PYTEST_BENCHMARK_INSTALLED: - benchmark = pytest.fixture(scope="function", name="benchmark")(_benchmark_compat) + + @pytest.fixture(scope="function") + def benchmark(codspeed_benchmark, request: pytest.FixtureRequest): + """ + Compatibility with pytest-benchmark + """ + return codspeed_benchmark