From d9462321ef10f02a059b7766bfd40299a0b06d41 Mon Sep 17 00:00:00 2001 From: remimd Date: Sat, 14 Nov 2026 18:04:02 +0100 Subject: [PATCH] feat: Mark Bus.subscribe as deprecated for type checkers Bus.subscribe is kept as a test helper, so the deprecation is static only (category=None): IDEs and type checkers flag it, no runtime warning. Co-Authored-By: Claude Opus 5.5 --- cq/_core/routing/dispatchers/bus.py | 11 +++++++++++ pyproject.toml | 1 + uv.lock | 2 ++ 3 files changed, 14 insertions(+) diff --git a/cq/_core/routing/dispatchers/bus.py b/cq/_core/routing/dispatchers/bus.py index c367e11..609e3c2 100644 --- a/cq/_core/routing/dispatchers/bus.py +++ b/cq/_core/routing/dispatchers/bus.py @@ -1,3 +1,4 @@ +import sys from abc import ABC, abstractmethod from collections.abc import Awaitable, Callable, Iterator from typing import Any, Concatenate, Protocol, Self, runtime_checkable @@ -14,6 +15,11 @@ SingleHandlerRegistry, ) +if sys.version_info >= (3, 13): # pragma: no cover + from warnings import deprecated +else: # pragma: no cover + from typing_extensions import deprecated + type Listener[T] = Callable[[T], Awaitable[Any]] @@ -29,6 +35,11 @@ def add_listeners(self, *listeners: Listener[I]) -> Self: def add_middlewares(self, *middlewares: Middleware[Concatenate[I, ...], O]) -> Self: raise NotImplementedError + @deprecated( + "`Bus.subscribe` is intended for tests, register handlers with the router " + "decorators (`command_handler`, `event_handler`, `query_handler`) instead.", + category=None, + ) @abstractmethod def subscribe( self, diff --git a/pyproject.toml b/pyproject.toml index 57ccb13..2d459d5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -48,6 +48,7 @@ classifiers = [ dependencies = [ "anyio", "type-analyzer", + "typing-extensions; python_version < '3.13'", ] [project.optional-dependencies] diff --git a/uv.lock b/uv.lock index d1d8e4d..cc488ba 100644 --- a/uv.lock +++ b/uv.lock @@ -1073,6 +1073,7 @@ default-groups = ["dev", "docs", "test"] dependencies = [ { name = "anyio" }, { name = "type-analyzer" }, + { name = "typing-extensions", marker = "python_full_version < '3.13'" }, ] [package.optional-dependencies] @@ -1101,6 +1102,7 @@ requires-dist = [ { name = "anyio" }, { name = "python-injection", extras = ["async"], marker = "extra == 'injection'" }, { name = "type-analyzer" }, + { name = "typing-extensions", marker = "python_full_version < '3.13'" }, ] provides-extras = ["injection"]